Pass global event dispatcher into SDK PromptBuilder#67
Open
shadyvb wants to merge 1 commit intoWordPress:trunkfrom
Open
Pass global event dispatcher into SDK PromptBuilder#67shadyvb wants to merge 1 commit intoWordPress:trunkfrom
shadyvb wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Prompt_Builder constructed the vendored PromptBuilder without the optional EventDispatcherInterface, so BeforeGenerateResultEvent / AfterGenerateResultEvent never reached WordPress hooks. Wire AiClient::getEventDispatcher() into the wrapper so wp_ai_client_before_generate_result and wp_ai_client_after_generate_result fire after AI_Client::init(). Adds a regression test asserting the inner builder shares the global dispatcher. Fixes WordPress#66 Made-with: Cursor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Author
|
@felixarntz Any chance we can merge this is for parity with core? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
Prompt_Builder constructed the vendored PromptBuilder without the optional
EventDispatcherInterface, soBeforeGenerateResultEvent/AfterGenerateResultEventnever reached WordPress hooks.Wire AiClient::getEventDispatcher() into the wrapper so
wp_ai_client_before_generate_resultandwp_ai_client_after_generate_resultfire after AI_Client::init().Adds a regression test asserting the inner builder shares the global dispatcher.