Repository navigation
Fix Serde UTC deserialisation and remove column fields from Message::$meta_keys #614
Description
Part of #302. Blocks #303 and #307. Related: #372.
What problem does this address?
Model\Message::$meta_keysincludesexpires_atandseverity, which are dedicated columns.encode_meta()therefore writes{"date":"…","timezone_type":3,"timezone":"UTC"}intometaand duplicatesseverity.jsonSerialize()happens to override both afterwards, which is why this hasn't been caught.- Serde deserialisation of dates doesn't reliably round-trip as UTC. Every date assertion elsewhere depends on this.
channel_titleshould also leave$meta_keys; otherwise it sneaks back into themetablob once the column is dropped (Removing the channel title in the messages table #372).
What is your proposed solution?
- Remove
expires_at,severityandchannel_titlefromMessage::$meta_keys. - Fix Serde so dates deserialise as UTC; add
tests/phpunit/tests/test-serde.phpcovering the round trip. - Drop
validate_message()if no longer needed. - Update
test-model-message.php, which pins the exact JSON output.
Activity
huzaifaalmesbah commentedon Oct 16, 2026
Hi @jonathanbossenger, I'd like to work on this one.
I've reproduced both parts:
Serde::maybe_deserialize_mysql_date()callsDateTime::createFromFormat()without a timezone, so dates are read in the PHP default timezone. WordPress sets that to UTC, but anything that changes it shifts every date. It also accepts dates like2024-02-30, which PHP silently rolls over to March.Message::$meta_keysincludesexpires_at,severityandchannel_title, soencode_meta()writes them into themetaJSON.Plan: read and write dates in UTC explicitly, remove the three keys from
$meta_keyswhile keeping them injsonSerialize(), drop the unusedvalidate_message(), addtests/phpunit/tests/test-serde.phpand updatetest-model-message.php. I'll open a PR shortly.Model: Handle dates in UTC in Serde and the message factory (WordPres…