Conversation
0894b7e to
874d184
Compare
874d184 to
d781277
Compare
iandunn
left a comment
There was a problem hiding this comment.
This looks good 👍🏻
It might be good to have the linter run on PRs too, but this is a good first step.
| @@ -0,0 +1,5 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
I wonder if this would be better as a pre-push hook? I often make lots of WIP commits locally, and it can be annoying for the linter to run on those, since they're not intended to pass.
There was a problem hiding this comment.
It used to support pre-push, but the usage for the new version has changed, and pre-push doesn't seem to work anymore 🤔 I've tried for a while and also checked if others have encountered the same issue, but no good news. Let me do more research to see if I can find a solution.
There was a problem hiding this comment.
Ok, it's not a huge deal if we keep it pre-commit, especially if later on we add an action to do it on push.
bb77506 to
8954ae1
Compare
I'll add it when I circle back to this PR later. I'll proceed to other higher-priority tasks at the moment, |
|
That makes sense 👍🏻 The GH action isn't a high priority. |
This PR
Screenshots
lint:js
lint:css