feat: Add new system icons and update existing - #48
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR expands the Canvas system icon set by adding multiple new system icons, updating icon metadata (including categories/tags), and introducing deprecated aliases/fallbacks for some legacy icons.
Changes:
- Added new system icons (SVG assets) and corresponding entries in
system.metadata.json. - Updated metadata categories for several existing icons and introduced new metadata entries for additional icons.
- Added deprecated metadata + deprecated SVG aliases intended to map legacy icon names to newer replacements.
Reviewed changes
Copilot reviewed 2 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/canvas-icons/system.metadata.json | Adds metadata entries for new icons and updates categories for some existing icons. |
| packages/canvas-icons/system.deprecated.metadata.json | Adds new deprecated icon metadata entries and reorganizes an existing deprecated entry. |
| packages/canvas-icons/src/system/wd-icon-user-check.svg | Updates the SVG paths for the user-check icon. |
| packages/canvas-icons/src/system/wd-icon-umbrella.svg | Adds new umbrella icon SVG. |
| packages/canvas-icons/src/system/wd-icon-table-row.svg | Updates the SVG paths for the table-row icon. |
| packages/canvas-icons/src/system/wd-icon-table-header.svg | Adds new table-header icon SVG. |
| packages/canvas-icons/src/system/wd-icon-table-column.svg | Adds new table-column icon SVG. |
| packages/canvas-icons/src/system/wd-icon-square-rotate.svg | Adds new square-rotate icon SVG. |
| packages/canvas-icons/src/system/wd-icon-snowflake.svg | Adds new snowflake icon SVG. |
| packages/canvas-icons/src/system/wd-icon-rich-text.svg | Adds new rich-text icon SVG. |
| packages/canvas-icons/src/system/wd-icon-pipeline.svg | Adds new pipeline icon SVG. |
| packages/canvas-icons/src/system/wd-icon-lotus.svg | Adds new lotus icon SVG. |
| packages/canvas-icons/src/system/wd-icon-line-spacing-increase.svg | Adds new line-spacing-increase icon SVG. |
| packages/canvas-icons/src/system/wd-icon-line-spacing-decrease.svg | Adds new line-spacing-decrease icon SVG. |
| packages/canvas-icons/src/system/wd-icon-indent-precise.svg | Adds new indent-precise icon SVG. |
| packages/canvas-icons/src/system/wd-icon-indent-increase.svg | Adds new indent-increase icon SVG. |
| packages/canvas-icons/src/system/wd-icon-indent-decrease.svg | Adds new indent-decrease icon SVG. |
| packages/canvas-icons/src/system/wd-icon-font-superscript.svg | Adds new font-superscript icon SVG. |
| packages/canvas-icons/src/system/wd-icon-font-subscript.svg | Adds new font-subscript icon SVG. |
| packages/canvas-icons/src/system/wd-icon-document-number.svg | Adds new document-number icon SVG. |
| packages/canvas-icons/src/system/wd-icon-document-break.svg | Adds new document-break icon SVG. |
| packages/canvas-icons/src/system/wd-icon-couch.svg | Adds new couch icon SVG. |
| packages/canvas-icons/src/system/wd-icon-cloud-sun.svg | Adds new cloud-sun icon SVG. |
| packages/canvas-icons/src/system/wd-icon-cloud-rain.svg | Adds new cloud-rain icon SVG. |
| packages/canvas-icons/src/system/wd-icon-cloud-bolt.svg | Adds new cloud-bolt icon SVG. |
| packages/canvas-icons/src/system/wd-icon-cell-split.svg | Adds new cell-split icon SVG. |
| packages/canvas-icons/src/system/wd-icon-cell-repeat.svg | Adds new cell-repeat icon SVG. |
| packages/canvas-icons/src/system/wd-icon-cell-merge.svg | Adds new cell-merge icon SVG. |
| packages/canvas-icons/src/system/wd-icon-car.svg | Adds new car icon SVG. |
| packages/canvas-icons/src/system/wd-icon-button-pointer.svg | Adds new button-pointer icon SVG. |
| packages/canvas-icons/src/system/wd-icon-bolt-strikethrough.svg | Adds new bolt-strikethrough icon SVG. |
| packages/canvas-icons/src/system/wd-icon-arrow-up-small.svg | Updates the SVG paths for arrow-up-small. |
| packages/canvas-icons/src/system/wd-icon-arrow-right-small.svg | Updates the SVG paths for arrow-right-small. |
| packages/canvas-icons/src/system/wd-icon-arrow-left-small.svg | Updates the SVG paths for arrow-left-small. |
| packages/canvas-icons/src/system/wd-icon-arrow-down-small.svg | Updates the SVG paths for arrow-down-small. |
| packages/canvas-icons/src/system/deprecated/wd-icon-remove-indent.svg | Adds deprecated SVG alias for remove-indent. |
| packages/canvas-icons/src/system/deprecated/wd-icon-line-spacing-shrink.svg | Adds deprecated SVG alias for line-spacing-shrink. |
| packages/canvas-icons/src/system/deprecated/wd-icon-line-spacing-grow.svg | Adds deprecated SVG alias for line-spacing-grow. |
| packages/canvas-icons/src/system/deprecated/wd-icon-indent.svg | Adds deprecated SVG alias for indent. |
Suppressed comments (3)
packages/canvas-icons/system.deprecated.metadata.json:2841
line-spacing-growappears in both system.metadata.json and system.deprecated.metadata.json. If this is meant to be deprecated, it should not also remain in the active metadata list, otherwise consumers may continue to treat it as supported/non-deprecated.
packages/canvas-icons/system.deprecated.metadata.json:3802- This icon is now listed in both the active metadata (system.metadata.json) and the deprecated metadata (system.deprecated.metadata.json). If the intent is to deprecate
remove-indent, it should be removed (or otherwise marked) in the active metadata to avoid duplicate/conflicting definitions.
packages/canvas-icons/system.deprecated.metadata.json:2857 line-spacing-shrinkappears in both system.metadata.json and system.deprecated.metadata.json. This duplication can leave the icon effectively non-deprecated for consumers that only read the active metadata file.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Issue
#XXX
Summary
This pull request updates the
system.deprecated.metadata.jsonfile in thecanvas-iconspackage to improve the accuracy and completeness of deprecated icon metadata.New Icons:
bolt-strikethrough,button-pointer,car,cell-merge,cell-repeat,cell-split,cloud-bolt,cloud-rain,cloud-sun,couch,document-break,document-number,font-subscript,font-superscript,indent-precise,lotus,pipeline,rich-text,snowflake,square-rotate,table-column,table-header,umbrellaIcon updates:
Updated styles:
user-checkarrow-up-smallarrow-down-smallarrow-right-smallarrow-left-smalltable-rowAdded deprecated metadata entries for the following editor icons, each with appropriate fallback replacements:
indent(fallback:wd-icon-indent-increase.svg)remove-indent(fallback:wd-icon-indent-decrease.svg)line-spacing-grow(fallback:wd-icon-line-spacing-increase.svg)line-spacing-shrink(fallback:wd-icon-line-spacing-decrease.svg)Release Category
Icons