Fix temporalConstraints null check in default effectiveRoles script. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krausvo1
force-pushed
the
effective_roles_fix
branch
from
600e88f
to
24bdd58
Compare
|
This needs to be addressed in repo component because there are multiple places that expect those properties ( I guess we need to add support to treat DB |
|
I am closing this in favor of #202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The null check was not working in case of
object.temporalConstraints === null, which can happen when using e.g. postgres database.While I was at it I also simplified the constraints processing code.