Skip to content

Conversation

@yueliao11
Copy link
Contributor

…ed Reranker (zero-dependency via Requests) to rescore candidates.- Update RagRetriever to use RRF (Reciprocal Rank Fusion) for merging Vector and BM25 results.- Enhance BM25 tokenization with regex for better code retrieval.- Add RAG_RERANK_PROVIDER configuration support (OpenAI/OpenRouter).

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18d33b177f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 85 to 86
) rag_dir=rag_dir,
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove stray tokens that break module parsing

The return statement in get_default_config has an extra rag_dir=rag_dir, and closing ) after the constructor call, which makes spoon_ai/rag/config.py invalid Python. This will raise a SyntaxError on import, so any code path that imports the RAG config (e.g., retriever initialization) will fail immediately at startup.

Useful? React with 👍 / 👎.

…ed Reranker (zero-dependency via Requests) to rescore candidates.- Update RagRetriever to use RRF (Reciprocal Rank Fusion) for merging Vector and BM25 results.- Enhance BM25 tokenization with regex for better code retrieval.- Add RAG_RERANK_PROVIDER configuration support (OpenAI/OpenRouter).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant