Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TraktForVLC.py: fix TVDB keys #78

Closed
wants to merge 1 commit into from
Closed

TraktForVLC.py: fix TVDB keys #78

wants to merge 1 commit into from

Conversation

keikoro
Copy link

@keikoro keikoro commented Sep 29, 2017

@keikoro
Copy link
Author

keikoro commented Sep 30, 2017

See #77

@XaF
Copy link
Owner

XaF commented Nov 17, 2017

I'm kind of confused as TraktForVLC is running fine on my end without that change.
Do you have an actual error without that change ?

@keikoro
Copy link
Author

keikoro commented Nov 17, 2017

Hi, I'm currently on the go so will have to postpone any fixes until tomorrow (also, I need access to my other machine on which I'm using TraktForVLC).

I don't think this threw an error per se, just that it didn't return the needed values for the video to be recognised. I only investigated when I noticed that several series episodes which were neither "weirdly" named nor unknown to Trakt weren't scrobbled.

Are you saying you get the correct values even when not using the (new) TVDB keys? (I.e. the API still returns values for the old keys?) Even so, wouldn't it make sense to reflect the changes to the API in the code?

@XaF
Copy link
Owner

XaF commented Apr 16, 2018

TraktForVLC 2.x makes that issue obsolete - #88
It's using the new keys as it was rewritten from scratch with the last API version.

Thanks!

@XaF XaF closed this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants