Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlcrc: return str for file name, title #79

Closed
wants to merge 1 commit into from
Closed

vlcrc: return str for file name, title #79

wants to merge 1 commit into from

Conversation

keikoro
Copy link

@keikoro keikoro commented Sep 30, 2017

Return strings instead of byte strings for get_filename() and get_title(). Fixes #77 for Python 3.

@keikoro
Copy link
Author

keikoro commented Sep 30, 2017

Uh, just realised my PR is a variation of #76...

@XaF
Copy link
Owner

XaF commented Nov 17, 2017

Just restarted the tests for #76 - If they pass, I'll merge this other one as it's in the same direction

@keikoro
Copy link
Author

keikoro commented Dec 25, 2017

Looks like the builds for the linked PR failed for the same reason the ones for my approved PR #82 failed:

TASKKILL : ERROR: The process with PID 1920 (child process of PID 2832) could not be terminated.
At line:1 char:96
+ ...  timeouted; if ($timeouted) { TASKKILL /PID $TestPid.Id /F /T; } else ...
+                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (ERROR: The proc... be terminated.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
Reason: There is no running instance of the task.
Command executed with exception: Reason: There is no running instance of the task.

@keikoro
Copy link
Author

keikoro commented Dec 25, 2017

Interestingly, I'm getting a new error now sometimes when using the code I submitted here (not always though). It includes an URL that doesn't seem to exist at all on IMDB... http://www.imdb.com/xml/find?tt=on&json=1&q=Movie+Title&nr=1

2017-12-25 03:47:43,703::TraktForVLC::DEBUG::valid_Movie::no valid title found
Traceback (most recent call last):
  File "PATH_TO_REPO/TraktForVLC/TraktForVLC.py", line 685, in valid_Movie
    vlcFilePath, vlcTitle, vlcYear, vlcDuration)
  File "PATH_TO_REPO/TraktForVLC/movie_info.py", line 155, in get_movie_info
    search = imdb.search_for_title(movie_name)
  File "PATH_TO_VENV/versions/trakt4vlc/lib/python3.4/site-packages/imdbpie/imdbpie.py", line 148, in search_for_title
    'http://www.imdb.com/xml/find?{0}'.format(query_params)
  File "PATH_TO_VENV/versions/trakt4vlc/lib/python3.4/site-packages/imdbpie/imdbpie.py", line 286, in _get
    resp.raise_for_status()
  File "PATH_TO_VENV/versions/trakt4vlc/lib/python3.4/site-packages/requests/models.py", line 935, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http://www.imdb.com/xml/find?tt=on&json=1&q=Movie+Title&nr=1
2017-12-25 03:47:43,800::TraktForVLC::INFO::No tv show nor movie found for the current playing video

Not sure if this also happens on master though, as I can't use the code on master (I always run into the buffer error included in #77 and then the script just stops).

@keikoro
Copy link
Author

keikoro commented Dec 25, 2017

Ok, after updating all libraries installed with pip, I'm getting other errors. Not sure if it makes sense to put them in a new issue though as they cannot be reproduced by using the current master...

@XaF
Copy link
Owner

XaF commented Apr 16, 2018

TraktForVLC 2.x makes that PR obsolete - #88

@XaF XaF closed this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants