Use set width datatypes instead of long long/long #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracc
changed the title
dracc
force-pushed
the
intfix
branch
2 times, most recently
from
5e872b9 to
2931f51
Compare
|
lgtm 👍 Hopefully a maintainer can merge this soon. |
|
Do you have any idea what exactly fixes it? Indiscriminately using explicit width data types, especially for status codes, is not very idiomatic |
JayFoxRox
reviewed
May 26, 2021
| ssize_t wrote; | ||
| xoff_t curpos; | ||
| int fp = -1, err = 0; | ||
| int32_t fp = -1, err = 0; |
There was a problem hiding this comment.
This change is almost certainly bad. Because fp is a file handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might/Could/Should fix the "64 bit build breaks images" issue.