Fixed bug in nextcloud auth #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Will merge shortly. |
|
I wouldnt know how to resolve this, there is no develop branch that i can see |
Sorry, that's not an issue. Looks like some snyk checks are not necessary. |
|
Perfect, thanks |
|
@Dacid99 merge successful, but for some reason you are not added by Github to the contributors. I will sort it out. |
|
I forcibly added you via a commit message "Co-authored-by: PR Author Name [email protected]". I'm not sure about the reason why you were not automatically added by Github, does it have to do with your email configuration at github? |
|
Ill look into it, thanks a lot for sorting this out, I probably wouldnt even have noticed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the browser intent runs on its own thread and so the poll() method is called without waiting for the browser activity to finish. So as the token is not authenticated yet, this leads to the 404. I moved this call to poll() to a method that is called when the app resumes after the browser is finished.
All my tests work now, so this resolves #49