eflatency: compute the mean from the timings array#240
Closed
osresearch wants to merge 1 commit intoXilinx-CNS:masterfrom
Closed
eflatency: compute the mean from the timings array#240osresearch wants to merge 1 commit intoXilinx-CNS:masterfrom
osresearch wants to merge 1 commit intoXilinx-CNS:masterfrom
Conversation
This patch changes how the mean column in eflatency is computed to use the sum of the per-message timings, instead of the overall time that the test used. That way things that are outside of the timing loop do not affect the computation of the mean and the mean value reflects the min/50/90/95/max values in the other columns. For most users this will result in a slight decrease of their mean times, although ideally it should be very close for the default case.
Contributor
|
Thank you @osresearch. Although I understand the motivation, I don't think we can apply this patch because it might confuse the users and give a wrong impression of the performance improvement since the Meanwhile, I'll let @jfeather-amd follow up at #238. |
Author
|
I see that a similar change has been merged in the v9.0.0 branch in yaml output mode dd61f46 so this can be closed. |
Contributor
Thanks for the initial suggestion @osresearch . If you want to raise any other PR building on dd61f46 , we're happy to take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes how the mean column in eflatency is computed to use the sum of the per-message timings, instead of the overall time that the test used. That way things that are outside of the timing loop do not affect the computation of the mean and the mean value reflects the min/50/90/95/max values in the other columns.
For most users this will result in a slight decrease of their mean times, although ideally it should be very close for the default case.