Open
Conversation
Contributor
|
Do you really have an application which uses select() in such a way? I used to believe that all "new" applications use poll or epoll, and the only use-case for select() is "a small application with 5 file descriptors". If you propose some complicated code, then this code should be tested (i.e. there should be a new test in Socket Tester https://github.com/Xilinx-CNS/cns-sapi-ts) and maintained (together with the tests). Is there any reason for adding such kind of code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Discrete Mode to select.
This mode is designed to optimize scenarios where file descriptors (fds) are scattered and the smallest fd within the fdset is relatively large.
In such cases, it locates the smallest user-defined fd in the fastest possible manner, instead of iterating from 0.
For loops can sometimes become a significant performance bottleneck, especially in non-blocking mode with select.
While this mode does not guarantee performance gains universally, it provides substantial improvement when the smallest user-defined fd is low (e.g., 32).
If the smallest fd is 1000, citp_ul_select executes over 20 times faster compared to the conventional iterative approach.
such as:
The citp_ul_select function requires only two iterations to retrieve the user-configured value of fd 64.