update orm_json to show sockets in SYN_RECV state#308
Open
okt-kosovnn wants to merge 2 commits intoXilinx-CNS:masterfrom
Open
update orm_json to show sockets in SYN_RECV state#308okt-kosovnn wants to merge 2 commits intoXilinx-CNS:masterfrom
okt-kosovnn wants to merge 2 commits intoXilinx-CNS:masterfrom
Conversation
This function is needed to log information of TCP_SYN_RECV sockets in orm_json. Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am>
There is no CI_TCP_SYN_RECV state in Onload. As said in Onload: For each listening socket we have a list of SYNRECV buffs, one for each SYN we've received for which there hasn't yet been an ACK. i.e. on receipt of SYN we make a synrecv buf, then send the SYNACK. The on receipt of the ACK of the SYNACK, we 'promote' the synrecv buffer to a fully fledged end-point. We call this list the listenq. However information from this list was not logged in output of orm_json. Therefore there was no information in orm_json output about sockets in TCP_SYN_RECV state. Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am>
okt-kosovnn
added a commit
to okt-kosovnn/cns-sapi-ts
that referenced
this pull request
Dec 4, 2025
TCP_SYN_RECV is added to orm_json output in Xilinx-CNS/onload#308 AMD-Jira-ID: ST-2731 Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am>
okt-kosovnn
added a commit
to okt-kosovnn/cns-sapi-ts
that referenced
this pull request
Dec 5, 2025
TCP_SYN_RECV should be added to the orm_json output in Xilinx-CNS/onload#308. Once this change is merged, the tcp_get_state_from_tool() call with "te_onload_stdump netstat" in tcp_get_state() in talib_sockapi_ts/rpc.c can be removed. AMD-Jira-ID: ST-2731 Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am>
okt-kosovnn
added a commit
to okt-kosovnn/cns-sapi-ts
that referenced
this pull request
Dec 5, 2025
TCP_SYN_RECV should be added to the orm_json output in Xilinx-CNS/onload#308. Once this change is merged, the tcp_get_state_from_tool() call with "te_onload_stdump netstat" in tcp_get_state() in talib_sockapi_ts/rpc.c can be removed. AMD-Jira-ID: ST-2731 Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am>
okt-kosovnn
added a commit
to okt-kosovnn/cns-sapi-ts
that referenced
this pull request
Dec 5, 2025
TCP_SYN_RECV should be added to the orm_json output in Xilinx-CNS/onload#308. Once this change is merged, the tcp_get_state_from_tool() call with "te_onload_stdump netstat" in tcp_get_state() in talib_sockapi_ts/rpc.c can be removed. AMD-Jira-ID: ST-2731 Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am> Reviewed-by: Yurij Plotnikov <yurij.plotnikov@arknetworks.am>
okt-kosovnn
added a commit
to okt-kosovnn/cns-sapi-ts
that referenced
this pull request
Dec 8, 2025
TCP_SYN_RECV should be added to the orm_json output in Xilinx-CNS/onload#308. Once this change is merged, the tcp_get_state_from_tool() call with "te_onload_stdump netstat" in tcp_get_state() in talib_sockapi_ts/rpc.c can be removed. AMD-Jira-ID: ST-2731 Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am> Reviewed-by: Yurij Plotnikov <yurij.plotnikov@arknetworks.am>
okt-kosovnn
added a commit
to okt-kosovnn/cns-sapi-ts
that referenced
this pull request
Dec 9, 2025
TCP_SYN_RECV should be added to the orm_json output in Xilinx-CNS/onload#308. Once this change is merged, the tcp_get_state_from_tool() call with "te_onload_stdump netstat" in tcp_get_state() in talib_sockapi_ts/rpc.c can be removed. AMD-Jira-ID: ST-2731 Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am> Reviewed-by: Yurij Plotnikov <yurij.plotnikov@arknetworks.am>
okt-yurijp
pushed a commit
to Xilinx-CNS/cns-sapi-ts
that referenced
this pull request
Dec 9, 2025
TCP_SYN_RECV should be added to the orm_json output in Xilinx-CNS/onload#308. Once this change is merged, the tcp_get_state_from_tool() call with "te_onload_stdump netstat" in tcp_get_state() in talib_sockapi_ts/rpc.c can be removed. AMD-Jira-ID: ST-2731 Signed-off-by: Nikolai Kosovskii <nikolai.kosovskii@arknetworks.am> Reviewed-by: Yurij Plotnikov <yurij.plotnikov@arknetworks.am>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no CI_TCP_SYN_RECV state in Onload. As said in Onload:
For each listening socket we have a list of SYNRECV buffs, one for each
SYN we've received for which there hasn't yet been an ACK. i.e. on
receipt of SYN we make a synrecv buf, then send the SYNACK. The on
receipt of the ACK of the SYNACK, we 'promote' the synrecv buffer to a
fully fledged end-point. We call this list the listenq.
However information from this list was not logged in output of orm_json.
Therefore there was no information in orm_json output about sockets in
TCP_SYN_RECV state.
The situation is close to how onload_stackdump netstat shows sockets in SYN_RECV state.
Here is the example of new output (only tcp_listenq_bucket is new JSON object)
orm_json_all.json