The onload-dkms package requires libcap-dev.

[lukester1975]

Hi

E.g. if installed in a minimal system that didn't generate the debs in the first place, the module build will fail.

I guess there's an argument to include more of the Build-Depends if requiring dkms (and build-essential transiently) doesn't bring in all the required deps, but I've not personally had a problem other than libcap-dev.

RPM looks OK due to user_build_requires for the akmod spec, AFAICT.

Thanks!

[abower-amd]

Hi @lukester1975,

Thanks for spotting, reporting and proposing a fix for this!

My first thought is that there must be a bug if the kernel module build (which AIUI should be pure kernel module for DKMS/AKMOD/kmod RPM) relies on a userspace library, even if just for a handy numerical definition from a header file or in test code, so we should fix that bug instead.

That said, if we are at present relying implicitly on this then we could arguably admit as such in the package definition until such time as we have fixed (eliminated) the underlying dependency.

[lukester1975]

Sure, makes sense. It's months since I tripped over it so don't recall anything further, but from a quick look I guess ci_is_sysadmin()?

Thanks