ap_private: Initialize data member in default constructor to avoid compilation warnings #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplilation warnings
|
@luciferlee @MattSnow-amd can you please merge this? I see it's been open for a year now. |
tomeichlersmith
added a commit
to LDMX-Software/ldmx-sw
that referenced
this pull request
Sep 25, 2024
tomeichlersmith
added a commit
to LDMX-Software/ldmx-sw
that referenced
this pull request
Sep 25, 2024
* dont use a float as a for-loop counter
replace this with a while loop instead to be more clear about the possibility of rounding errors affecting performance
* remove unnecessary member variables holding digis, rename and align numbering of digi collections
* more compiler warning patches
- update digis{1,2,3} collection variable names
- remove useless (int) casts
- remove unused int index = count variables
* remove unnecessary zero-ing of count after its use
* Apply clang-format
* dont specify HLS includes as a specific directory
we include them as a SYSTEM include in central CMakeLists.txt
and specifying them as SYSTEM informs CMake and its downstream compilers
to avoid analyzing them since they aren't our problem
* require value initialization in Firmware-mimic structs
* Add checks in TrigScintFirmwareTracker, and fix array sizes, add defaults
* copy HLS APT submodule into ldmx-sw proper under Tools
* update readme notes
* rename etc and hide private headers in the ap_impl directory
* fix up paths in includes so examples compile
* attach HLS APT headers as 'system' headers to Tools module
* remove inclusion of directory that doesn't exist anymore
* patch inclusion of directories to correctly specify them as system headers
* cleanup TS CMakeLists and specify Tools as dependency of Firmware
* add patch from PR #1
Xilinx/HLS_arbitrary_Precision_Types#1
* wrap unknown pragmas in ifdef so they can be ignored here
* remove unused centroid variable
* Apply clang-format
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tamas Vami <[email protected]>
|
We (ATLAS experiment at CERN) are also very much interested in getting this merged. And thanks to our CMS colleagues for upstreaming their fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the compilation warnings like [a]. Both
VALandpValare properly initialized in allap_privateconstructor except the default one. This PR explicitly initialize these data members on default constructor too.[a]