Check elf magic before elf header size #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address pull request Xilinx#20
Checking elf header size before elf magic may lead to presenting the user with a misleading error message in case the elf file header is corrupted or a non-elf file was entered into the bif file instead of an elf file (for example bl31.bin instead of bl31.elf.
Instead of receiving the misleading error message:
[ERROR] : ELF Parsing Error !!!
Wrong Header Size
The user is now presented with a more accurate error message:
[ERROR] : ELF Parsing Error !!!
ELF magic identification word wrong
|
Aren't both messages printed no matter the order of the checks? |
|
No, |
|
I see (you mean |
kalvdans
approved these changes
Jul 5, 2023
|
Yes, |
msreeram-xilinx
force-pushed
the
master
branch
from
1795f18 to
73cd336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking elf header size before elf magic may lead to presenting the user with a misleading error message in case the elf file header is corrupted or a non-elf file was entered into the bif file instead of an elf file (for example bl31.bin instead of bl31.elf.
Instead of receiving the misleading error message:
[ERROR] : ELF Parsing Error !!!
Wrong Header Size
The user is now presented with a more accurate error message:
[ERROR] : ELF Parsing Error !!!
ELF magic identification word wrong