Fixes avg pool 3d #171
Merged
Fixes avg pool 3d #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sad, the new test is failing. I guess I missed something :( |
mgehre-amd
approved these changes
Jun 10, 2024
The previous conversions for AtenAdaptiveAvgPool1dOp and AtenAdaptiveMaxPool2dOp are refactored into a general templated conversion that works for all of the AtenAdaptive...PoolNdOp's. New support is added for the following ops: 1. AtenAdaptiveMaxPool1d 2. AtenAdaptiveMaxPool3d 3. AtenAdaptiveAvgPool3d Support is also provided for passing inputs without batch dimensions. For example, applying adaptive_avg_pool2d to an input tensor of rank 3. After [pytorch #118162](pytorch/pytorch#118162) gets down to torch-mlir, I'll add a test for AdaptiveMaxPool1d with return_indices (which will pass with that upstream fix). --------- Co-authored-by: James Newling <[email protected]>
This commit also fixes the average pool op' test failing for OnnxToLinalg lowering. Signed-Off By: Vivek Khandelwal <[email protected]>
Support for the operator in HLO has been implemented in llvm#3259 but that change is not in this fork yet.
josel-amd
force-pushed
the
jose.fix_avg_pool_3d
branch
from
09da441 to
862fcca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in