Skip to content

refactor(web): 생년월일 입력 및 검증 공통화 - #272

Merged
pbk95120 merged 1 commit into
developfrom
refactor/birth-date-validation
Sep 11, 2026
Merged

pbk95120 merged 1 commit into
developfrom
refactor/birth-date-validation

Conversation

@pbk95120

@pbk95120 pbk95120 commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

📝 작업 내용 요약

  • 온보딩과 내 정보 수정 화면에 중복된 생년월일 입력 포맷·ISO 변환·날짜 검증을 공통 함수로 모았습니다.
  • 기존 UI와 오류 문구를 유지했습니다.
  • 부분 입력, 윤년, 오늘·미래 날짜 경계 테스트를 추가했습니다.

✅ 체크리스트

  • develop 브랜치의 최신 코드를 pull 받았나요? (origin/develop에서 새 브랜치 생성)
  • 빌드가 통과했나요?
  • vitest 테스트가 통과했나요? (웹 443개)
  • Playwright e2e가 통과했나요? (28개)

🤖 AI 리뷰

Claude 리뷰 (Codex 구현)

  • 구현: Codex gpt-5.6-luna, max.
  • Claude Opus 5 리뷰를 시도했으나 Not logged in · Please run /login으로 실행하지 못했습니다.
  • 사용자 승인으로 독립 AI 리뷰를 생략했습니다. 리뷰 통과 판정은 없습니다.
  • lint, typecheck, test, build 전체 20개 작업 통과.

💬 기타 코멘트

  • 생체인증과 북마크 동작 정책 변경은 이번 PR에서 제외했습니다.

변경 사항

  • apps/web/lib/birth-date.ts에 생년월일 입력 포맷팅, ISO 변환, 실재 날짜 검증, 과거 날짜 검증 함수를 추가했습니다.
  • 온보딩과 내 정보 수정 화면에서 공통 생년월일 함수를 사용하도록 변경했습니다.
  • 윤년, 부분 입력, 오늘 및 미래 날짜 경계를 포함한 유틸리티 테스트를 추가했습니다.

@pbk95120 pbk95120 self-assigned this Sep 11, 2026
@pbk95120
pbk95120 requested a review from jongse7 September 11, 2026 06:27
@vercel

vercel Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
28th-web-team-3-fe-web-dev Ready Ready Preview Sep 11, 2026 6:27am UTC
1 Skipped Deployment
Project Deployment Actions Updated
28th-web-team-3-fe-admin Ignored Ignored Sep 11, 2026 6:27am UTC

@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 9b17c217-df3d-4fef-8468-0553d2165f72

📥 Commits

Reviewing files that changed from the base of the PR and between 61d9826 and a2dc40c.

📒 Files selected for processing (4)
  • apps/web/app/onboarding/(questions)/age/page.tsx
  • apps/web/app/profile/edit/page.tsx
  • apps/web/lib/birth-date.test.ts
  • apps/web/lib/birth-date.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

생년월일 처리 함수를 공용 모듈로 통합했다. 온보딩과 프로필 편집 화면이 공용 함수를 사용한다. 실제 날짜, 윤년, 과거 날짜 검증 테스트를 추가했다.

Changes

생년월일 처리 공통화

Layer / File(s) Summary
공용 생년월일 유틸리티
apps/web/lib/birth-date.ts, apps/web/lib/birth-date.test.ts
입력값을 YYYY.MM.DD 형식으로 정규화하고 ISO 형식으로 변환하는 함수를 추가했다. 실제 날짜와 과거 날짜를 검증하는 함수를 추가하고 테스트했다.
온보딩 생년월일 연동
apps/web/app/onboarding/(questions)/age/page.tsx
페이지 내부 생년월일 로직을 공용 함수 import로 교체했다. 입력 변경 시 toIsoBirthDate를 사용한다.
프로필 생년월일 연동
apps/web/app/profile/edit/page.tsx
로컬 생년월일 함수를 제거하고 공용 함수를 import한다. 제출 시 실제 날짜와 과거 날짜를 পৃথ개별 검증한다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to a2dc4

The shared birth-date changes preserve the reviewed onboarding and profile flows with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 생년월일 입력 및 검증 로직을 공통화하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/birth-date-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pbk95120
pbk95120 merged commit 58905ab into develop Sep 11, 2026
7 checks passed
@pbk95120
pbk95120 deleted the refactor/birth-date-validation branch September 11, 2026 08:26

This branch was successfully deployed

1 active deployment
Preview – 28th-web-team-3-fe-web-dev — a2dc40c7 Deployed Sep 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant