Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshot: make selection area modifiable via keybinds #1279

Merged
merged 3 commits into from
Mar 29, 2025

Conversation

nnyyxxxx
Copy link
Contributor

resolves #980

@nnyyxxxx nnyyxxxx marked this pull request as ready for review March 16, 2025 10:04
@nnyyxxxx nnyyxxxx requested a review from YaLTeR March 27, 2025 00:32
@YaLTeR YaLTeR enabled auto-merge (squash) March 29, 2025 07:36
@YaLTeR YaLTeR merged commit 7dc015e into YaLTeR:main Mar 29, 2025
12 checks passed
@YaLTeR
Copy link
Owner

YaLTeR commented Mar 29, 2025

Thanks.

Your original implementation had some problems:

  • moving outside the boundaries would reset the selection to the default rather than clamping
  • resizing ignored the change and instead used a hardcoded value
  • moving and resizing didn't take output scale into account

So I reimplemented it to do all of this.

Now, having tried it, the next logical steps are:

  • support switch-preset-window-width/height
    • basically do the same as layout/floating.rs. Will be a bit annoying to keep track of preset widths/heights so that they're the same as in the layout Options
  • support move-window-to-monitor-right/left/up/down to move the selection across monitors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make floating move & resize work on the screenshot UI area
2 participants