refactor: simplify youtube-url helpers and reduce test duplication#12
Merged
Conversation
Removed single-use wrapper functions (normalizeHostname, normalizePathname, hasNonEmptyValue) and inlined their logic. Eliminated redundant double-normalization of hostnames and removed dead null-guard checks. Collapsed appendVideoUrlPrompt's three-way return into a single expression with computed separator. Extracted getToolbarButtons helper in regen-flow tests to deduplicate the repeated 3-button query and null-assertion pattern across three tests. Removed unused isYouTubeUrl export which had no production consumers. All tests pass (67 tests, down from 68 due to removed unused function test).
YishenTu
force-pushed
the
youtube-url-gemini-flow
branch
from
ce71e40 to
ca2e5a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified the YouTube URL detection module by removing single-use wrapper functions and inlining their logic. Reduced redundant operations and dead code paths. Extracted test helper to eliminate duplication across three related test cases.
Key changes:
normalizeHostname,normalizePathname,hasNonEmptyValuewrapper functionsisYouTubeVideoPathisYouTubeUrlexport (no production consumers)appendVideoUrlPromptthree-way return into single expressiongetToolbarButtonstest helper to deduplicate button queryingAll 67 unit tests pass. TypeScript and Biome lint clean.