feat: slash command card gallery settings UI#16
Merged
Conversation
- Add slash command definitions, validation, resolution, and menu UI - Render slash commands as a 2-column card gallery in settings page - Default cards to view mode; editor opens only on explicit Edit click - Fix editor visibility bug where flex display overrode hidden attribute - Use data-slash-command-mode CSS selectors for view/edit toggling - Add userDisplayText metadata for resolved slash command display - Include comprehensive unit tests for slash commands and settings
- Merge duplicate mention/slash-command CSS rules into shared selectors - Consolidate redundant early-return blocks in resolveSlashCommandText - Simplify updateSelection by removing redundant branch - Remove unused SlashCommandRowMode type alias - Remove redundant outer guard around attachment preview checks
- Add fireSlashCommandAutosave wrapper with .catch() to surface storage write failures via status message instead of silently dropping them - Add .catch() to chrome.storage.local.get in slash command menu init to prevent unhandled promise rejections - Reuse createTitleMetaButton utility in slash command menu to reduce duplication with tab mention menu - Add unit tests for renderContentForChat with userDisplayText metadata - Add unit tests for normalizeContent userDisplayText in camelCase and snake_case forms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display: flexoverrode thehiddenattributedata-slash-command-modeCSS selectors for view/edit togglinguserDisplayTextmetadata for resolved slash command display in chatTest plan
bun test tests/unit/options/— 35 tests passbun test tests/unit/shared/settings.test.ts— passes