⚡ Bolt: optimize matchUrl by caching pathCandidates and method upper-casing - #104
Conversation
Caching `pathCandidates(url.pathname)` to prevent O(N) evaluations in the route matching loop. Hoisted method uppercasing outside the loop as well.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-Authored-By: Claude <noreply@anthropic.com>
💡 What: Lazily cache
pathCandidatesresult within thematchUrlrouter loop, and compute method uppercase outside the loop.🎯 Why: URL normalizations in
pathCandidatesloop up to 8 times running URL decoding and replacements. Doing this O(N) times inside the router loop causes severe degradation in performance when there are many configured routes.📊 Impact: Reduces router execution time from O(N) string processing back to near O(1) by computing the normalizations only once per request.
🔬 Measurement: Run vitest on packages/jouska/test/unit/router.test.ts to verify the behavior remains completely intact and tests pass.
PR created automatically by Jules for task 18054138350319212640 started by @YoungSx