Skip to content

[misc]: code optimisations of typing class, typos and grammar - #83

Open
wthrajat wants to merge 5 commits into
Yuri-SVB:mainfrom
wthrajat:fractalNow
Open

[misc]: code optimisations of typing class, typos and grammar#83
wthrajat wants to merge 5 commits into
Yuri-SVB:mainfrom
wthrajat:fractalNow

Conversation

@wthrajat

@wthrajat wthrajat commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

This PR fixes:

NOTE: Nothing to test or screen-record before and after as no functionality has been changed.

PR Checklist:

  • All new features have been tested (nothing to test)
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct
  • All new features have been documented (nothing to document)

Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>

@MuhammadMuradG MuhammadMuradG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good typos catching. However, I prefer split this PR to 2 PRs to address each of the mentioned problems separately (one PR for typos and one PR for Union class). We can bypass this splitting problem in this PR and adopting splitting strategy of different tasks in the future PRs.

Changed in version 3.10: Unions can now be written as X | Y. See union type expressions.

Regarding to the adopting | instead of Union in typing module, I think this will limit the Python versions supported by our application to 3.10+ instead of 3.8+. Do we really need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants