Skip to content

๐Ÿ› fix: ํ”„๋ก ํŠธ์—”๋“œ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ ์ฃผ์†Œ๋ฅผ ๋ฐฐํฌ๋œ ์ฃผ์†Œ๋กœ ๋ณ€๊ฒฝ - #41

Merged
ThreeeJ merged 1 commit into
mainfrom
fix/#11
May 11, 2026

Conversation

@ThreeeJ

@ThreeeJ ThreeeJ commented May 11, 2026

Copy link
Copy Markdown
Contributor

๐Ÿ” ๊ด€๋ จ ์ด์Šˆ


โœ… ์ž‘์—… ๋ถ„๋ฅ˜

  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ์‹ ๊ทœ ๊ธฐ๋Šฅ
  • ํ”„๋กœ์ ํŠธ ๊ตฌ์กฐ ๋ณ€๊ฒฝ
  • ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
  • ๊ธฐ๋Šฅ ์ˆ˜์ •

โœจ ์ž‘์—… ๋‚ด์šฉ

  • ํ”„๋ก ํŠธ์—”๋“œ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ ์ฃผ์†Œ๋ฅผ ๋ฐฐํฌ๋œ ์ฃผ์†Œ๋กœ ๋ณ€๊ฒฝ

๐Ÿ‘ฅ ์ „๋‹ฌ์‚ฌํ•ญ

  • ์ถ”ํ›„ ๋กœ์ปฌ๊ณผ ๋ฐฐํฌ ์„œ๋ฒ„ ํ™˜๊ฒฝ ๋ถ„๊ธฐ ์ฒ˜๋ฆฌ ์˜ˆ์ •

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ฝ”๋“œ๊ฐ€ ์ปดํŒŒ์ผ ๋ฐ ๋นŒ๋“œ๋จ
  • ๋ชจ๋“  ํ…Œ์ŠคํŠธ๊ฐ€ ํ†ต๊ณผํ•จ
  • ๊ด€๋ จ ๋ฌธ์„œ๊ฐ€ ์—…๋ฐ์ดํŠธ๋จ
  • ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€๋ฅผ ํ™•์ธํ•จ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท


๐Ÿ’ก ๋ฐฐ์šด ๊ฒƒ / ์‹œ๋„ํ•œ ๊ฒƒ / ๊ณ ๋ฏผํ•œ ์ 

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OAuth2 frontend redirect URI from a local development address to a production Netlify URL. The review feedback suggests using an environment variable with a default value instead of hardcoding the production URL, which allows for better flexibility across different environments and prevents the need for manual code changes during local development.


# Frontend
app.oauth2.front-redirect-uri=http://localhost:5173/oauth/callback
app.oauth2.front-redirect-uri=https://z-igma.netlify.app/oauth/callback

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

์šด์˜ ํ™˜๊ฒฝ์˜ ์ฃผ์†Œ๋ฅผ ์„ค์ • ํŒŒ์ผ์— ์ง์ ‘ ๊ธฐ๋กํ•˜๋ฉด ๋กœ์ปฌ ๊ฐœ๋ฐœ ํ™˜๊ฒฝ์—์„œ ๋งค๋ฒˆ ์ฝ”๋“œ๋ฅผ ์ˆ˜์ •ํ•ด์•ผ ํ•˜๋Š” ๋ฒˆ๊ฑฐ๋กœ์›€์ด ๋ฐœ์ƒํ•ฉ๋‹ˆ๋‹ค. ํ”„๋กœ์ ํŠธ ๋‚ด ๋‹ค๋ฅธ ์„ค์ •(JWT ๋“ฑ)๊ณผ ๋™์ผํ•˜๊ฒŒ ํ™˜๊ฒฝ ๋ณ€์ˆ˜๋ฅผ ์‚ฌ์šฉํ•˜๊ณ , ๊ธฐ๋ณธ๊ฐ’์œผ๋กœ ๋กœ์ปฌ ์ฃผ์†Œ๋ฅผ ์ง€์ •ํ•˜๋Š” ๋ฐฉ์‹์„ ๊ถŒ์žฅํ•ฉ๋‹ˆ๋‹ค. ์ด๋ ‡๊ฒŒ ํ•˜๋ฉด ๋ฐฐํฌ ํ™˜๊ฒฝ(Netlify ๋“ฑ)์—์„œ FRONT_REDIRECT_URI ํ™˜๊ฒฝ ๋ณ€์ˆ˜๋งŒ ์„ค์ •ํ•˜์—ฌ ์•ˆ์ „ํ•˜๊ฒŒ ์šด์˜ ์ฃผ์†Œ๋ฅผ ์ ์šฉํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

app.oauth2.front-redirect-uri=${FRONT_REDIRECT_URI:http://localhost:5173/oauth/callback}

@ThreeeJ
ThreeeJ merged commit 36442c4 into main May 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant