Skip to content

Adding 5 tests that were failing on me: [ wtq-00080, wtq-00085, wtq-00113, wtq-00162, wtq-00168] #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronibhakta1 merged 7 commits into from
Apr 23, 2026
Merged

Adding 5 tests that were failing on me: [ wtq-00080, wtq-00085, wtq-00113, wtq-00162, wtq-00168] #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a0019ce
5 failing tests
Apr 14, 2026
d05f41d
Add test_roundtrip_benchmarks.py to assert roundtrip accuracy-- 5 of …
Apr 19, 2026
f4bc7e2
coderabbit nitpicks
Apr 20, 2026
027c909
Fix boolean-like dictionary keys being converted to booleans
Apr 12, 2026
0b4a487
Fix dictionary header values not being quoted
Apr 12, 2026
6824a8a
remove null pointer comment
Apr 12, 2026
0bdef33
Exclude float columns from delta encoding
Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 128 additions & 0 deletions zon-format/benchmarks/data/wtq-00080.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
[
{
"Year": "1996",
"Driver": "Karim Hirji",
"Co-driver": "Frank Nekusa",
"Car": "Toyota Celica ST 185",
"Notes": "Run under FIA rules as the Great Lakes Rally, jointly with Club Automobile du Burundi"
},
{
"Year": "1997",
"Driver": "Chipper Adams",
"Co-driver": "Justin Beyendeza",
"Car": "Toyota Supra",
"Notes": "Run as the Pearl of Africa Uganda Rally - ARC Candidate event"
},
{
"Year": "1998",
"Driver": "Charles Muhangi",
"Co-driver": "Steven Byaruhanga",
"Car": "Subaru Impreza",
"Notes": ""

@coderabbitai coderabbitai Bot Apr 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use one missing-value representation across the dataset.

This file mixes "" and "-" for unavailable values, which can make encode/decode normalization and retrieval assertions brittle.

Proposed normalization patch (use JSON nulls for missing fields) 
-    "Notes": ""
+    "Notes": null
-    "Driver": "-",
-    "Co-driver": "-",
-    "Car": "-",
+    "Driver": null,
+    "Co-driver": null,
+    "Car": null,

Also applies to: 28-28, 35-35, 39-41, 49-49, 56-57, 63-64, 70-71, 84-85, 91-92, 105-106, 112-113, 119-120, 126-127

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@zon-format/benchmarks/data/wtq-00080.json` at line 21, The file mixes empty
strings ("") and hyphens ("-") for missing values—normalize all
missing/unavailable fields in this JSON to use JSON null instead; specifically
replace occurrences of the "Notes" field and other empty/hyphen values (e.g.,
the entries referenced at lines 28, 35, 39-41, 49, 56-57, 63-64, 70-71, 84-85,
91-92, 105-106, 112-113, 119-120, 126-127) so their values are null, ensuring
consistent encode/decode behavior across functions that read these records.

},
{
"Year": "1999",
"Driver": "Chipper Adams",
"Co-driver": "Justin Beyendeza",
"Car": "Toyota Supra",
"Notes": ""
},
{
"Year": "2000",
"Driver": "Charlie Lubega",
"Co-driver": "Abed Musa",
"Car": "Mitsubishi Lancer Evo 4",
"Notes": ""
},
{
"Year": "2001",
"Driver": "-",
"Co-driver": "-",
"Car": "-",
"Notes": "Event not run"
},
{
"Year": "2002",
"Driver": "Johnny Gemmel",
"Co-driver": "Robert Paisley",
"Car": "Subaru Impreza WRX",
"Notes": ""
},
{
"Year": "2003",
"Driver": "Charlie Lubega",
"Co-driver": "Abed Musa",
"Car": "Mitsubishi Lancer Evo 4",
"Notes": ""
},
{
"Year": "2004",
"Driver": "Charlie Lubega",
"Co-driver": "Abed Musa",
"Car": "Mitsubishi Lancer Evo 4",
"Notes": ""
},
{
"Year": "2005",
"Driver": "Riyaz Kurji",
"Co-driver": "Sayed Kadri",
"Car": "Subaru Impreza N10",
"Notes": ""
},
{
"Year": "2006",
"Driver": "Riyaz Kurji",
"Co-driver": "Sayed Kadri",
"Car": "Subaru Impreza N8",
"Notes": "Crew run under Kenyan Licence"
},
{
"Year": "2007",
"Driver": "Conrad Rautenbach",
"Co-driver": "Peter Marsh",
"Car": "Subaru Impreza N10",
"Notes": ""
},
{
"Year": "2008",
"Driver": "Jamie Whyte",
"Co-driver": "Phil Archenoul",
"Car": "Subaru Impreza N10",
"Notes": ""
},
{
"Year": "2009",
"Driver": "Riyaz Kurji",
"Co-driver": "Sayed Kadri",
"Car": "Subaru Impreza N8",
"Notes": "Price granted posthumously"

@coderabbitai coderabbitai Bot Apr 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix likely typo in Notes text (Price → Prize).

This looks like a spelling error and can reduce benchmark retrieval quality if tests compare expected phrasing.

Proposed text fix 
-    "Notes": "Price granted posthumously"
+    "Notes": "Prize granted posthumously"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Notes": "Price granted posthumously"
"Notes": "Prize granted posthumously"
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@zon-format/benchmarks/data/wtq-00080.json` at line 98, Update the JSON entry
where the "Notes" field currently contains the typo "Price granted
posthumously": change the string value to "Prize granted posthumously" by
editing the "Notes" key in the affected record so the wording is correct.

},
{
"Year": "2010",
"Driver": "Jamie Whyte",
"Co-driver": "Phil Archenoul",
"Car": "Subaru Impreza N10",
"Notes": ""
},
{
"Year": "2011",
"Driver": "Ponsiano Lwakataka",
"Co-driver": "Musa Nsubuga",
"Car": "Subaru Impreza N8",
"Notes": ""
},
{
"Year": "2012",
"Driver": "Mohammed Essa",
"Co-driver": "Greg Stead",
"Car": "Subaru Impreza N12",
"Notes": ""
},
{
"Year": "2013",
"Driver": "Jas Mangat",
"Co-driver": "Gihan de Silva",
"Car": "Mitsubishi Lancer Evo X",
"Notes": ""
}
]
135 changes: 135 additions & 0 deletions zon-format/benchmarks/data/wtq-00085.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
[
{
"Region": "Netherlands",
"Date": "April 19, 2004",
"Label": "Magik Muzik",
"Format": "vinyl, 12\"",
"Catalog": "Magik Muzik 817-5"
},
{
"Region": "Netherlands",
"Date": "April 19, 2004",
"Label": "Magik Muzik",
"Format": "CD, Maxi",
"Catalog": "Magik Muzik 817-2"
},
{
"Region": "Netherlands",
"Date": "April 19, 2004",
"Label": "Magik Muzik",
"Format": "CD, Single",
"Catalog": "Magik Muzik 817-1"
},
{
"Region": "Germany",
"Date": "May, 2004",
"Label": "Kontor Records",
"Format": "CD, Maxi",
"Catalog": "Kontor375"
},
{
"Region": "Germany",
"Date": "April 8, 2004",
"Label": "Kontor Records",
"Format": "vinyl, 12\"",
"Catalog": "Kontor375"
},
{
"Region": "Australia",
"Date": "April, 2004",
"Label": "Bang On!",
"Format": "vinyl, 12\"",
"Catalog": "BANG 056"
},
{
"Region": "Australia",
"Date": "May, 2004",
"Label": "Bang On!",
"Format": "CD, Maxi",
"Catalog": "BANG0096"
},
{
"Region": "United Kingdom",
"Date": "April 30, 2004",
"Label": "Nebula",
"Format": "CD, Maxi, Enhanced",
"Catalog": "NEBCD058"
},
{
"Region": "United Kingdom",
"Date": "April 30, 2004",
"Label": "Nebula",
"Format": "CD, Single, Promo",
"Catalog": "NEBCDDJ058"
},
{
"Region": "United Kingdom",
"Date": "April 30, 2004",
"Label": "Nebula",
"Format": "vinyl, 12\", Promo",
"Catalog": "NEBDJ058"
},
{
"Region": "United Kingdom",
"Date": "April 30, 2004",
"Label": "Nebula",
"Format": "CD, Maxi",
"Catalog": "NEBT058"
},
{
"Region": "Switzerland",
"Date": "June, 2004",
"Label": "Sirup",
"Format": "CD, Maxi",
"Catalog": "SIR021-1CD"
},
{
"Region": "Switzerland",
"Date": "June, 2004",
"Label": "Sirup",
"Format": "CD, Maxi",
"Catalog": "MV-SIR903572"
},
{
"Region": "Switzerland",
"Date": "June, 2004",
"Label": "Sirup",
"Format": "vinyl, 12\"",
"Catalog": "SIR021-6"
},
{
"Region": "United States",
"Date": "2004",
"Label": "Nettwerk America",
"Format": "vinyl, 12\"",
"Catalog": "0 6700 33227 1 3"
},
{
"Region": "United States",
"Date": "May, 2004",
"Label": "Nettwerk America",
"Format": "CD, Single",
"Catalog": "0 6700 33227 2 0"
},
{
"Region": "France",
"Date": "2004",
"Label": "Independence Records",
"Format": "vinyl, 12\"",
"Catalog": "IR 0408"
},
{
"Region": "Italy",
"Date": "June 5, 2004",
"Label": "Media Records",
"Format": "vinyl, 12\"",
"Catalog": "MR 2013"
},
{
"Region": "Scandinavia",
"Date": "2004",
"Label": "Playground Music Scandinavia",
"Format": "CD, Maxi",
"Catalog": "Magik Muzik 817-2"
}
]
128 changes: 128 additions & 0 deletions zon-format/benchmarks/data/wtq-00113.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
[
{
"Year": "1996",
"Driver": "Karim Hirji",
"Co-driver": "Frank Nekusa",
"Car": "Toyota Celica ST 185",
"Notes": "Run under FIA rules as the Great Lakes Rally, jointly with Club Automobile du Burundi"
},
{
"Year": "1997",
"Driver": "Chipper Adams",
"Co-driver": "Justin Beyendeza",
"Car": "Toyota Supra",
"Notes": "Run as the Pearl of Africa Uganda Rally - ARC Candidate event"
},
{
"Year": "1998",
"Driver": "Charles Muhangi",
"Co-driver": "Steven Byaruhanga",
"Car": "Subaru Impreza",
"Notes": ""
},
{
"Year": "1999",
"Driver": "Chipper Adams",
"Co-driver": "Justin Beyendeza",
"Car": "Toyota Supra",
"Notes": ""
},
{
"Year": "2000",
"Driver": "Charlie Lubega",
"Co-driver": "Abed Musa",
"Car": "Mitsubishi Lancer Evo 4",
"Notes": ""
},
{
"Year": "2001",
"Driver": "-",
"Co-driver": "-",
"Car": "-",
"Notes": "Event not run"
},
{
"Year": "2002",
"Driver": "Johnny Gemmel",
"Co-driver": "Robert Paisley",
"Car": "Subaru Impreza WRX",
"Notes": ""
},
{
"Year": "2003",
"Driver": "Charlie Lubega",
"Co-driver": "Abed Musa",
"Car": "Mitsubishi Lancer Evo 4",
"Notes": ""
},
{
"Year": "2004",
"Driver": "Charlie Lubega",
"Co-driver": "Abed Musa",
"Car": "Mitsubishi Lancer Evo 4",
"Notes": ""
},
{
"Year": "2005",
"Driver": "Riyaz Kurji",
"Co-driver": "Sayed Kadri",
"Car": "Subaru Impreza N10",
"Notes": ""
},
{
"Year": "2006",
"Driver": "Riyaz Kurji",
"Co-driver": "Sayed Kadri",
"Car": "Subaru Impreza N8",
"Notes": "Crew run under Kenyan Licence"
},
{
"Year": "2007",
"Driver": "Conrad Rautenbach",
"Co-driver": "Peter Marsh",
"Car": "Subaru Impreza N10",
"Notes": ""
},
{
"Year": "2008",
"Driver": "Jamie Whyte",
"Co-driver": "Phil Archenoul",
"Car": "Subaru Impreza N10",
"Notes": ""
},
{
"Year": "2009",
"Driver": "Riyaz Kurji",
"Co-driver": "Sayed Kadri",
"Car": "Subaru Impreza N8",
"Notes": "Price granted posthumously"

@coderabbitai coderabbitai Bot Apr 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Possible typo in Notes text (Price vs Prize).

Line 98 reads “Price granted posthumously”, which likely should be “Prize granted posthumously”. This can affect retrieval assertions that depend on exact wording.

Proposed fix 
-    "Notes": "Price granted posthumously"
+    "Notes": "Prize granted posthumously"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Notes": "Price granted posthumously"
"Notes": "Prize granted posthumously"
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@zon-format/benchmarks/data/wtq-00113.json` at line 98, The "Notes" field
contains a typo: replace the string "Price granted posthumously" with "Prize
granted posthumously" in the JSON entry so retrievals and assertions match
expected wording; locate the entry with the "Notes" key in wtq-00113.json and
update its value accordingly.

},
{
"Year": "2010",
"Driver": "Jamie Whyte",
"Co-driver": "Phil Archenoul",
"Car": "Subaru Impreza N10",
"Notes": ""
},
{
"Year": "2011",
"Driver": "Ponsiano Lwakataka",
"Co-driver": "Musa Nsubuga",
"Car": "Subaru Impreza N8",
"Notes": ""
},
{
"Year": "2012",
"Driver": "Mohammed Essa",
"Co-driver": "Greg Stead",
"Car": "Subaru Impreza N12",
"Notes": ""
},
{
"Year": "2013",
"Driver": "Jas Mangat",
"Co-driver": "Gihan de Silva",
"Car": "Mitsubishi Lancer Evo X",
"Notes": ""
}
]
Loading
Loading