Repository navigation
feat(search): Search here on every browse screen, and say what it searches - #594
Merged
wizzomafizzo merged 1 commit intoNov 3, 2026
Merged
Conversation
…rches
"Search here..." now opens a scoped search from Systems (the category's
systems), Favorite systems and Favorites (all favorites, or one system's),
as well as from a Games folder. Recently played has none: Core cannot
limit a search to play history.
- The Search screen's title and the 240p header read "Search in {}" with
the folder, system, category or Favorites. The System field shows the
whole scope and never lists every system of a category.
- A folder's tag filter carries into its search, one way.
- The favorites scope sends user:favorite outside the Tags field, so it
cannot be cleared there. A chosen List tag includes hidden games, as
browse does.
- Back returns to the screen the search was opened from.
- Results name a category or Favorites where the systems go, composed in
the view so the name is translated; a saved tile takes that name.
- Systems gains a Menu row with Search here; at 240p Menu runs it. Favorite
systems' 240p Menu becomes a list of Group by and Search here.
- Search results say "Save to Hub", with "Saved to Hub" and "Save to Hub
failed" to match. Game, system and folder Options keep "Add to Hub".
- Persisted search state gains scope_kind and scope_category. An older
scoped search loads as a folder scope; an unknown kind loads unscoped.
Closes #542
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
wizzomafizzo
deleted the
investigate-issue-542-folder-search-discoverability
branch
November 3, 2026 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Search here…" opens a scoped search from every browse screen Core can scope a search to, and the Search screen now says what it is limited to. Before, the only cue was the System field's label changing to "Search in".
Search here
user:favoriteuser:favorite, plus the system when viewing one system's favoritesuser:favoriteoutside the Tags field, so it cannot be cleared there. A chosen List tag includes hidden games, the same rule browse uses."mario" · Consoles · RPG), using the existing{} · {}string. Slint composes it so the name is translated. A tile saved from those results takes that name.Menu row
Save to Hub
State
SearchStategainsscope_kindandscope_category. An older state file with a scoped search loads as a folder scope; an unknown kind loads unscoped. No reset or migration.Test plan
just testpasses (1161 workspace, 490 MiSTer feature). New route tests cover Search here from a folder (carried tags, the folder's filter left unchanged), a category, Favorites with and without a system, and Favorite systems, Back from each, the Systems chip row, and the 240p Menu paths. Unit tests cover the scope tokens, the favorites tag, the hidden-games rule and loading older state.just lint: fmt, clippy (desktop, MiSTer, snapshot), toolkit, translations, notices and logos pass.cargo denyfails only onasync-executor 1.14.0being yanked upstream, which this change does not touch.Closes #542