feat: Add comprehensive Secp256K1-TR ciphersuite support for Bitcoin …#537
Open
wolfmcnally wants to merge 2 commits intoZcashFoundation:mainfrom
Open
feat: Add comprehensive Secp256K1-TR ciphersuite support for Bitcoin …#537wolfmcnally wants to merge 2 commits intoZcashFoundation:mainfrom
wolfmcnally wants to merge 2 commits intoZcashFoundation:mainfrom
Conversation
…taproot compatibility This commit implements full support for the Secp256K1-TR ciphersuite across all FROST tools, enabling Bitcoin taproot-compatible threshold signatures alongside existing Ed25519 and RedPallas support. ### Core Changes: - **Dependency Management**: Added frost-secp256k1-tr v2.1.0 to workspace and all relevant crates - **CLI Integration**: All command-line tools now accept `secp256k1-tr` as a ciphersuite option: - trusted-dealer: Generate threshold keys for Bitcoin taproot - dkg: Distributed key generation with Secp256K1-TR - coordinator: Coordinate signing sessions with taproot keys - participant: Participate in taproot threshold signing ### Implementation Details: - **Ciphersuite Helper**: Extended ciphersuite_helper.rs to map Secp256K1Sha256TR::ID to helper implementations - **CLI Dispatching**: Added string-to-type mapping for "secp256k1-tr" across all CLI entry points - **Trait Implementations**: Implemented MaybeIntoEvenY trait for Secp256K1Sha256TR (no-op, as even Y conversion not required) - **Type Safety**: Added proper type dispatching based on ciphersuite ID in all coordinator and participant modules ### Testing & Documentation: - **Integration Tests**: Added comprehensive test coverage for Secp256K1-TR in frostd integration tests - **README Updates**: Updated documentation to reflect three supported ciphersuites with usage examples - **Supply Chain**: Added frost-secp256k1-tr exemption to cargo-vet configuration ### Files Modified: - Cargo.toml files across workspace for dependency management - CLI modules for string-to-ciphersuite mapping - Helper functions for ciphersuite-specific operations - Integration test suite for complete flow verification - Documentation reflecting new Bitcoin taproot support ### Verification: - All existing tests continue to pass - New Secp256K1-TR integration test validates complete FROST signing flow - CLI tools accept and properly handle secp256k1-tr option across all workflows This enhancement maintains backward compatibility while extending FROST tools to support Bitcoin taproot transactions through threshold signatures, completing the multi-blockchain support matrix.
…into secp256k1-tr-support
Contributor
|
Thank you for this. We will take a further look shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…taproot compatibility
This commit implements full support for the Secp256K1-TR ciphersuite across all FROST tools, enabling Bitcoin taproot-compatible threshold signatures alongside existing Ed25519 and RedPallas support.
Core Changes:
secp256k1-tras a ciphersuite option:Implementation Details:
Testing & Documentation:
Files Modified:
Verification:
This enhancement maintains backward compatibility while extending FROST tools to support Bitcoin taproot transactions through threshold signatures, completing the multi-blockchain support matrix.