frost-client: refactored coordinator to work better as API#576
Open
conradoplg wants to merge 1 commit intopczt-supportfrom
Open
frost-client: refactored coordinator to work better as API#576conradoplg wants to merge 1 commit intopczt-supportfrom
conradoplg wants to merge 1 commit intopczt-supportfrom
Conversation
This was referenced Dec 26, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #574 which needs to be merge first.
The big change is removing any reference to input/output from the main code and leave it to the
Commsimplementation.Additionally, the signature is returned instead of being written to a file/printed (this logic has moved to the caller CLI code)
I haven't thoroughly tested if the old CLI workflow is working correctly, but the tests are passing. We might want to revisit the CLI/sockets options to review them or decide if we want to remove them.
There is a lot of stuff to improve still but I don't want to do everything in a single PR.