Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[onchain_js] Task 1: QuickBEAM foundation — Runtime module + supervised lifecycle (INE-52) #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
[onchain_js] Task 1: QuickBEAM foundation — Runtime module + supervised lifecycle (INE-52) #2
Changes from all commits
35083aaFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When callers use the documented
:scriptoption here to load a browser bundle,QuickBEAM.start/1evaluates that script beforestart_link/1returns, so there is no opportunity to callapply_browser_stubs/1first. Bundles that touchself,window,navigator, orlocationat top level will fail during startup despite this wrapper being the foundation for browser-bundle loading; the stubs need to be applied before loading the script, e.g. by starting the runtime without the script, stubbing, then loading/evaluating it.Useful? React with 👍 / 👎.