VorbisTag : Unit test for multiple values in additional fields

Zeugma440 · Jan 25, 2025 · 0a58537 · 0a58537
1 parent 2267f39
commit 0a58537
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 7 deletions.
diff --git a/ATL.unit-test/IO/HighLevel.cs b/ATL.unit-test/IO/HighLevel.cs
@@ -1005,7 +1005,7 @@ public void StreamedIO_R_Audio()
         [TestMethod]
         public void TagIO_R_VorbisFLAC_multipleArtists()
         {
-            string resource = "FLAC/multiple_artists.flac";
+            string resource = "FLAC/multiple_artists_custom.flac";
             string testFileLocation = TestUtils.CopyAsTempTestFile(resource);
 
             Track theTrack = new Track(testFileLocation);

diff --git a/ATL.unit-test/IO/MetaData/Vorbis_FLAC.cs b/ATL.unit-test/IO/MetaData/Vorbis_FLAC.cs
@@ -104,11 +104,11 @@ public void TagIO_R_VorbisFLAC_dirtyTrackDiscNumbering()
         }
 
         [TestMethod]
-        public void TagIO_RW_VorbisFLAC_multipleArtists()
+        public void TagIO_RW_VorbisFLAC_multipleArtistsCustom()
         {
             new ConsoleLogger();
 
-            string fileName = "FLAC/multiple_artists.flac";
+            string fileName = "FLAC/multiple_artists_custom.flac";
             string location = TestUtils.GetResourceLocationRoot() + fileName;
             string testFileLocation = TestUtils.CopyAsTempTestFile(fileName);
             AudioDataManager theFile = new AudioDataManager(AudioDataIOFactory.GetInstance().GetFromPath(testFileLocation));
@@ -122,10 +122,18 @@ public void TagIO_RW_VorbisFLAC_multipleArtists()
             // Read
             Assert.AreEqual("lovesick (feat. Punipuni Denki)", meta.Title);
             Assert.AreEqual("Kamome Sano" + ATL.Settings.InternalValueSeparator + "Punipuni Denki", meta.Artist);
+            string customStuff = "";
+            meta.AdditionalFields.TryGetValue("CUSTOMSTUFF", out customStuff);
+            Assert.AreEqual("1" + ATL.Settings.InternalValueSeparator + "2", customStuff);
 
             // Write same data and keep initial format
             TagHolder theTag = new TagHolder();
             theTag.Artist = "Kamome Sano" + ATL.Settings.DisplayValueSeparator + "Punipuni Denki";
+            var additionalFields = new Dictionary<string, string>
+            {
+                { "CUSTOMSTUFF", "1" + ATL.Settings.DisplayValueSeparator + "2" }
+            };
+            theTag.AdditionalFields = additionalFields;
             Assert.IsTrue(theFile.UpdateTagInFileAsync(theTag.tagData, MetaDataIOFactory.TagType.NATIVE).GetAwaiter().GetResult());
 
             // Check that the resulting file (working copy that has been tagged, then untagged) remains identical to the original file (i.e. no byte lost nor added)
@@ -139,6 +147,11 @@ public void TagIO_RW_VorbisFLAC_multipleArtists()
             // Write and modify
             theTag = new TagHolder();
             theTag.Artist = "aaa" + ATL.Settings.DisplayValueSeparator + "bbb" + ATL.Settings.DisplayValueSeparator + "ccc";
+            additionalFields = new Dictionary<string, string>
+            {
+                { "CUSTOMSTUFF", "1" + ATL.Settings.DisplayValueSeparator + "2" + ATL.Settings.DisplayValueSeparator + "3"}
+            };
+            theTag.AdditionalFields = additionalFields;
             Assert.IsTrue(theFile.UpdateTagInFileAsync(theTag.tagData, MetaDataIOFactory.TagType.NATIVE).GetAwaiter().GetResult());
 
             // Read again
@@ -149,6 +162,9 @@ public void TagIO_RW_VorbisFLAC_multipleArtists()
             Assert.IsTrue(meta.Exists);
 
             Assert.AreEqual("aaa" + ATL.Settings.InternalValueSeparator + "bbb" + ATL.Settings.InternalValueSeparator + "ccc", meta.Artist);
+            customStuff = "";
+            meta.AdditionalFields.TryGetValue("CUSTOMSTUFF", out customStuff);
+            Assert.AreEqual("1" + ATL.Settings.InternalValueSeparator + "2" + ATL.Settings.InternalValueSeparator + "3", customStuff);
 
             // Get rid of the working copy
             if (Settings.DeleteAfterSuccess) File.Delete(testFileLocation);

diff --git a/...test/Resources/FLAC/multiple_artists.flac → ...sources/FLAC/multiple_artists_custom.flac b/...test/Resources/FLAC/multiple_artists.flac → ...sources/FLAC/multiple_artists_custom.flac
diff --git a/ATL.unit-test/TestUtils.cs b/ATL.unit-test/TestUtils.cs
@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.IO;
-using System.Security.Cryptography;
+using System.Security.Cryptography;
 using System.Text;
 
 namespace ATL.test