Don't show warning when trying to remove additional fields on tagging…

… systems that don't support them [#316]

ATL/AudioData/IO/AA.cs

@@ -168,6 +168,10 @@ protected override MetaDataIOFactory.TagType getImplementedTagType()
             return MetaDataIOFactory.TagType.NATIVE;
         }
         /// <inheritdoc/>
+        protected override bool supportsPictures => true;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
+        /// <inheritdoc/>
         protected override Field getFrameMapping(string zone, string ID, byte tagVersion)
         {
             Field supportedMetaId = Field.NO_FIELD;

ATL/AudioData/IO/AIFF.cs

@@ -114,6 +114,8 @@ public AudioFormat AudioFormat
         }
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => false;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
 
         public long AudioDataOffset { get; set; }
         public long AudioDataSize { get; set; }

ATL/AudioData/IO/APEtag.cs

@@ -165,6 +165,10 @@ protected override MetaDataIOFactory.TagType getImplementedTagType()
 
         /// <inheritdoc/>
         protected override byte ratingConvention => RC_APE;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
+        /// <inheritdoc/>
+        protected override bool supportsPictures => true;
 
         /// <inheritdoc/>
         protected override Field getFrameMapping(string zone, string ID, byte tagVersion)

ATL/AudioData/IO/GYM.cs

@@ -69,6 +69,8 @@ class GYM : MetaDataIO, IAudioDataIO
         }
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => false;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
 
         // IMetaDataIO
         protected override int getDefaultTagOffset()

ATL/AudioData/IO/ID3v2.cs

@@ -491,7 +491,12 @@ protected override MetaDataIOFactory.TagType getImplementedTagType()
         }
 
         /// <inheritdoc/>
-        public override byte FieldCodeFixedLength => 0; // Actually 3 or 4 when strictly applying ID3v2.3 / ID3v2.4 specs, but thanks to TXXX fields, any code is supported
+        // Actually 3 or 4 when strictly applying ID3v2.3 / ID3v2.4 specs, but thanks to TXXX fields, any code is supported
+        public override byte FieldCodeFixedLength => 0; 
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
+        /// <inheritdoc/>
+        protected override bool supportsPictures => true;
 
 
         // ********************* Auxiliary functions & voids ********************

ATL/AudioData/IO/MKA.cs

@@ -250,6 +250,11 @@ public AudioFormat AudioFormat
 
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => true;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
+        /// <inheritdoc/>
+        protected override bool supportsPictures => true;
+
         protected override Field getFrameMapping(string zone, string ID, byte tagVersion)
         {
             Field supportedMetaId = Field.NO_FIELD;

ATL/AudioData/IO/MP4.cs

@@ -186,6 +186,10 @@ public bool isValid()
         }
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => true;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
+        /// <inheritdoc/>
+        protected override bool supportsPictures => true;
         public ChannelsArrangement ChannelsArrangement { get; private set; }
 
         public long AudioDataOffset { get; set; }

ATL/AudioData/IO/PSF.cs

@@ -100,6 +100,8 @@ public AudioFormat AudioFormat
         }
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => false;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
         public long AudioDataOffset { get; set; }
         public long AudioDataSize { get; set; }
 

ATL/AudioData/IO/SPC.cs

@@ -166,6 +166,8 @@ partial class SPC : MetaDataIO, IAudioDataIO
         }
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => false;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
 
         public long AudioDataOffset { get; set; }
         public long AudioDataSize { get; set; }

ATL/AudioData/IO/TwinVQ.cs

@@ -106,6 +106,8 @@ private sealed class HeaderInfo
         }
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => false;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
 
         public long AudioDataOffset { get; set; }
         public long AudioDataSize { get; set; }

ATL/AudioData/IO/VGM.cs

@@ -64,6 +64,8 @@ class VGM : MetaDataIO, IAudioDataIO
         }
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => false;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
 
         public long AudioDataOffset { get; set; }
         public long AudioDataSize { get; set; }

ATL/AudioData/IO/VorbisTag.cs

@@ -116,6 +116,11 @@ public VorbisTag(bool writePicturesWithMetadata, bool writeMetadataFramingBit, b
 
         protected override byte ratingConvention => RC_APE;
 
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
+        /// <inheritdoc/>
+        protected override bool supportsPictures => true;
+
         protected override Field getFrameMapping(string zone, string ID, byte tagVersion)
         {
             Field supportedMetaId = Field.NO_FIELD;

ATL/AudioData/IO/WAV.cs

@@ -126,6 +126,10 @@ public AudioFormat AudioFormat
         }
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => false;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
+        /// <inheritdoc/>
+        protected override bool supportsPictures => true;
 
         public long AudioDataOffset { get; set; }
         public long AudioDataSize { get; set; }

ATL/AudioData/IO/WMA.cs

@@ -189,6 +189,10 @@ private void Reset()
         }
         /// <inheritdoc/>
         public bool IsNativeMetadataRich => true;
+        /// <inheritdoc/>
+        protected override bool supportsAdditionalFields => true;
+        /// <inheritdoc/>
+        protected override bool supportsPictures => true;
 
         /// <inheritdoc/>
         protected override Field getFrameMapping(string zone, string ID, byte tagVersion)

ATL/AudioData/MetaDataIO.cs

@@ -174,6 +174,17 @@ public long Size
         /// </summary>
         protected virtual byte ratingConvention => RC_ID3v2;
 
+        /// <summary>
+        /// Indicate if the tagging system supports embedded pictures
+        /// </summary>
+        protected virtual bool supportsPictures => false;
+
+        /// <summary>
+        /// Indicate if the tagging system supports additional fields
+        /// NB : Usually true except when the fields are a fixed set
+        /// </summary>
+        protected virtual bool supportsAdditionalFields => false;
+
         /// <summary>
         /// Encode the given DateTime for the current tagging format
         /// </summary>
@@ -462,7 +473,7 @@ public async Task<bool> WriteAsync(Stream s, TagData tag, ProgressToken<float> w
             bool result = await surgeon.RewriteZonesAsync(s, writeAdapter, Zones, dataToWrite, Exists);
 
             // Update tag information without calling Read
-            if (result) tagData.IntegrateValues(dataToWrite);
+            if (result) tagData.IntegrateValues(dataToWrite, supportsPictures, supportsAdditionalFields);
 
             postprocessWrite(s);
 
@@ -518,8 +529,9 @@ private TagData prepareWrite(Stream r, TagData tag)
                 structureHelper.AddZone(0, 0);
             }
 
+            // Merge existing information + new tag information
             var dataToWrite = new TagData(tagData);
-            dataToWrite.IntegrateValues(tag); // Merge existing information + new tag information
+            dataToWrite.IntegrateValues(tag, supportsPictures, supportsAdditionalFields);
             dataToWrite.Cleanup();
 
             preprocessWrite(dataToWrite);