Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nuget_build_release.yml to prevent character escaping #314

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

kitsumed
Copy link
Contributor

@kitsumed kitsumed commented Feb 8, 2025

I'm glad to see the workflow worked flawlessly, however I noticed in the logs that during the release file creation the GitHub Action executed commands that did not exist. These commands were text surrounded by ``. This had the consequence of removing them from the release file, which made weird sentences on the NuGet release notes.

But more importantly, this may compromise the build workflow if you accidentally were to include any kind of ill-intended string in your release body. While linux and bash systems are not my zone of confort, I managed to find a way to create that file in a way that should ignore escape characters, or, at least, those surrounded by ``.

Prevent character escaping
@Zeugma440
Copy link
Owner

Thanks 😄

@Zeugma440 Zeugma440 merged commit 020be08 into Zeugma440:main Feb 9, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants