Split expectation and strategy computations#98
Draft
JeffersonYeh wants to merge 2 commits intoqvaluefrom
Draft
Conversation
Zinoex
reviewed
Mar 13, 2026
Owner
Zinoex
left a comment
Zinoex
left a comment
There was a problem hiding this comment.
Just small comments. The only really important is regarding views.
| prop = system_property(spec), | ||
| ) | ||
|
|
||
| # 2. extract strategy and compute V(s) = max_a Q(s, a) |
Owner
There was a problem hiding this comment.
Suggested change
| # 2. extract strategy and compute V(s) = max_a Q(s, a) | |
| # 2. extract strategy and compute V'(s) = max_a Q(s, a) |
| ismaximize(spec), | ||
| ) | ||
|
|
||
| # 3. post process |
Owner
There was a problem hiding this comment.
Suggested change
| # 3. post process | |
| # 3. post process to compute V(s) = g(s, V'(s)) where the definition of g depends on the objective |
| maximize, | ||
| ) where {R <: Real} | ||
|
|
||
| #TODO: can be threaded? |
Owner
There was a problem hiding this comment.
Leave it be for now - we can always change it later.
| ) where {R <: Real} | ||
|
|
||
| #TODO: can be threaded? | ||
| for jₛ in CartesianIndices(source_shape(model)) |
Owner
There was a problem hiding this comment.
Suggested change
| for jₛ in CartesianIndices(source_shape(model)) | |
| @inbounds for jₛ in CartesianIndices(source_shape(model)) |
|
|
||
| Vres[jₛ] = extract_strategy!( | ||
| strategy_cache, | ||
| Q[:, jₛ], |
Owner
There was a problem hiding this comment.
Let's try to avoid expensive copies (expensive = many allocations, not large allocations. Previously it was allocating and copying for every state).
Suggested change
| Q[:, jₛ], | |
| @view(Q[:, jₛ]), |
| # interleaved concat gives shape: (a1, a2) , (s1, s2) => (a1, s1, a2, s2) | ||
| dim = (action_values(mp)..., state_values(mp)...) | ||
| # concat gives shape: (a1, a2) , (s1, s2) => (a1, a2, s1, s2) | ||
| # (a, s) to access s more frequently due to column major |
Owner
There was a problem hiding this comment.
Suggested change
| # (a, s) to access s more frequently due to column major | |
| # (a, s) to access a more frequently due to column major |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.