fix: add .context() to dialoguer interact() calls (#167)#169
Merged
fix: add .context() to dialoguer interact() calls (#167)#169
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR improves CLI error reporting by enriching dialoguer interactive prompt failures with anyhow::Context, so IO/TTY issues identify which specific prompt or input operation failed (closes #167).
Changes:
- Wrapped
dialoguer::Select/Confirm/Password/Inputinteract()/interact_text()calls with.context(<message>)across the CLI. - Standardized context message wording for selection vs text entry prompts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/cli/init.rs |
Adds contextual error messages to init/setup prompts (URL, auth method, board selection, project key, story points field). |
src/cli/auth.rs |
Adds contextual error messages to login prompts (email/token and OAuth client credentials). |
src/cli/issue/helpers.rs |
Adds contextual error messages to team/user/asset disambiguation prompts and shared input helper. |
src/cli/issue/links.rs |
Adds contextual error messages to link type disambiguation prompts for link/unlink flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anyhow::Contextwrapping to all 19dialoguer::interact()andinteract_text()calls across 4 files"failed to prompt for board selection") instead of rawstd::io::Error"failed to read <thing>"for text input,"failed to prompt for <thing>"for selection/confirmFiles changed:
src/cli/init.rs(6),src/cli/auth.rs(4),src/cli/issue/helpers.rs(7),src/cli/issue/links.rs(2)Closes #167
Test plan
cargo fmt --check— no formatting issuescargo clippy -- -D warnings— zero warningscargo test— all tests pass (no behavioral change, only error message enrichment)