Skip to content

Create Code Review #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ningowo wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Create Code Review #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
426e342
Update README.md
ekezieb Mar 17, 2021
22aa376
Project 2 Code Review: index.html
ekezieb Mar 17, 2021
892c058
Merge pull request #1 from ekezieb/patch-1
Ziqing19 Mar 18, 2021
b67f0dc
Merge pull request #3 from ekezieb/patch-3
Ziqing19 Mar 18, 2021
0ca6d1a
Empty commit for code review
zacw7 Mar 18, 2021
1f27f46
Merge pull request #4 from zacw7/master
Ziqing19 Mar 18, 2021
a4df910
Create Code Review
ningowo Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Code Review
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
When signing up, there can be a indication of successfully doing so, now it just jump to the log in page.
And it will be better if there exists some restriction for the length of password.

Also it will be great if a user can click into the homepage of other user.
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# PhotoHub
# PhotoHub

README.md is very impressive. Very detailed and emplains the components of the project.

## Project Objective
Photohub is a platform that users can view, share and comment on their photos.
Expand Down
5 changes: 3 additions & 2 deletions public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,9 @@
<script type="module" src="javascripts/utils.js"></script>
<script type="module" src="javascripts/main.js"></script>
</head>

<body class="position-relative">
In your body, I would suggest having all your content be in a container as it could help keep your code organized and you'd be able to use some of the bootstraps' special attributes to style your code more easily.
Also, I would use the main tag to separate your navbar from your base content.
<body class="position-relative">
<!--NAV-->
<nav class="navbar position-sticky">
<div class="container px-lg-5">
Expand Down