Phpcompatibility checker v3 - #3
Open
Zombaya wants to merge 32 commits into
Open
Conversation
Zombaya
force-pushed
the
phpcompatibilityChecker-v3
branch
2 times, most recently
from
May 17, 2022 09:25
4988aa5 to
2ffe7cc
Compare
Zombaya
force-pushed
the
phpcompatibilityChecker-v3
branch
2 times, most recently
from
June 13, 2022 22:00
07258a2 to
fd5b6a9
Compare
Zombaya
force-pushed
the
phpcompatibilityChecker-v3
branch
6 times, most recently
from
June 27, 2022 19:55
b55c737 to
8ae4d92
Compare
There were remaining error-messages in the openssl-error-stack, resulting in an unexpected result in the unittest. This was solved by outputting all error-messages in Aws\CloudFront\Signer::__construct(). Another option would be to clear all error-messages in Aws\Test\CloudFront\SignerTest::_tearDown(), so tests would no longer interfer with eachother. The first solution was chosen since it would output all openssl-error-messages to the user, not only the first one, making it more complete.
Zombaya
force-pushed
the
phpcompatibilityChecker-v3
branch
from
June 27, 2022 21:28
8ae4d92 to
bce4721
Compare
There were remaining error-messages in the openssl-error-stack, resulting in an unexpected result in the unittest. This was solved by outputting all error-messages in Aws\CloudFront\Signer::__construct(). Another option would be to clear all error-messages in Aws\Test\CloudFront\SignerTest::_tearDown(), so tests would no longer interfer with eachother. The first solution was chosen since it would output all openssl-error-messages to the user, not only the first one, making it more complete.
Zombaya
force-pushed
the
phpcompatibilityChecker-v3
branch
from
August 11, 2022 19:02
9cf1e5a to
560a415
Compare
Zombaya
force-pushed
the
phpcompatibilityChecker-v3
branch
4 times, most recently
from
August 11, 2022 21:00
930bfb3 to
e989685
Compare
…dms/phpunit-arraysubset-asserts
Zombaya
force-pushed
the
phpcompatibilityChecker-v3
branch
from
September 2, 2022 13:56
44adc95 to
a5ebd0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for unittest