Repository navigation
Release v3.90.0 - #2074
Release v3.90.0#2074
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Regression Evidence |  |
The release announcement is a durable visible UI change. The PR changes latestAnnouncementId so the announcement is shown for users, and replaces the heading and three visible highlights in `webview… |
Add a Playwright Story Gallery visual test for the announcement dialog, preferably using the existing announcement-links story or a dedicated release-announcement story. Assert the v3.90.0 heading and representative release content, captu… |
| Description check | |
The description explains the release scope and lists validation steps, but it does not follow the required template. It omits the required approved GitHub Issue, completed pre-submission checklist, do… | Update the description to use the required sections. Add an approved issue reference such as "Closes: #123", describe the implementation details and reviewer focus, provide completed test results and repeatable test steps, complete the pre-… |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Security Boundaries No changed path matches the security failure conditions. The only runtime change updates ClineProvider.latestAnnouncementId, which is used to identify and record the displayed announcement, not to p…Persistence Integrity No changed persistence path meets the failure condition. The PR changes release metadata and latestAnnouncementIdonly. The announcement consumer compares that ID with persisted `lastShownAnnounceme…Lifecycle Resource Cleanup The changed lifecycle-related code only updates ClineProvider.latestAnnouncementId. Its unchanged consumers compare the ID and save it as announcement state; the patch adds no listener, watcher, pro…Title check The title clearly identifies the main change: release preparation for version 3.90.0. It is concise and specific. Full details: Security Boundaries
-
Explanation
No changed path matches the security failure conditions. The only runtime change updates
ClineProvider.latestAnnouncementId, which is used to identify and record the displayed announcement, not to process input or control approvals. The other changes update the package version, tests, changelogs, README files, and localized announcement strings. The added text contains no credentials, PII, executable commands, or credential-shaped literals, and it does not alter allowlist or approval logic.
Full details: Persistence Integrity
-
Explanation
No changed persistence path meets the failure condition. The PR changes release metadata and
latestAnnouncementIdonly. The announcement consumer compares that ID with persistedlastShownAnnouncementId(ClineProvider.ts:2769-2770), and the acknowledgement path still awaits the global-state write (webviewMessageHandler.ts:890-892;ClineProvider.ts:3142-3144). No changed non-awaited write, non-atomic write, missing rollback, or unpropagated persisted default is present.
Full details: Lifecycle Resource Cleanup
-
Explanation
The changed lifecycle-related code only updates
ClineProvider.latestAnnouncementId. Its unchanged consumers compare the ID and save it as announcement state; the patch adds no listener, watcher, provider, timer, task, cancellation, disposal, restart, or resource-management behavior. All other changes are release text, translations, package metadata, or test fixtures. No changed lifecycle path can leak a resource or duplicate work.
-
Full details: Regression Evidence
-
Explanation
The release announcement is a durable visible UI change. The PR changes
latestAnnouncementIdso the announcement is shown for users, and replaces the heading and three visible highlights inwebview-ui/src/i18n/locales/*/chat.json.Announcement.spec.tsxonly uses mocked translations and exact text assertions. The PR adds no Playwright visual test or screenshot baseline for the announcement dialog. Repository UI guidance requires a*.visual.tsxsnapshot for user-noticeable rendered changes.Resolution
Add a Playwright Story Gallery visual test for the announcement dialog, preferably using the existing
announcement-linksstory or a dedicated release-announcement story. Assert the v3.90.0 heading and representative release content, capture the required theme screenshot baseline with the repository Docker workflow, and commit the__screenshots__baseline.
Full details: Description check
-
Explanation
The description explains the release scope and lists validation steps, but it does not follow the required template. It omits the required approved GitHub Issue, completed pre-submission checklist, documentation impact, contributor-guideline confirmation, and contact information. The test plan also lists unchecked actions instead of completed or reproducible test results.
Resolution
Update the description to use the required sections. Add an approved issue reference such as "Closes:
#123", describe the implementation details and reviewer focus, provide completed test results and repeatable test steps, complete the pre-submission checklist, state the documentation impact, confirm the Contributor Guidelines, and add the required Discord username.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Review statusThanks for contributing. This comment tracks the review sequence and the next action. Current step: Awaiting fresh human maintainer or CODEOWNER approval. Automated review is complete for the latest commit but does not replace human approval. Review-state labels are managed by this workflow; do not edit them manually. |
GitHub Actions
Active
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
github-actions
Bot
added
coderabbit-review-active
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
github-actions
Bot
added
awaiting-maintainer
Summary
Release preparation for v3.90.0. This PR includes the final version bump, changelog updates, Marketplace README updates, and announcement changes.
3.90.0on the stable even-minor line, cut frommainata06127157.Test plan
src/package.jsonis3.90.0andCHANGELOG.mdheading is## [3.90.0].v3.90.0on this branch tip and approve the marketplace deployment.