Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust SIMD legend into quintiles and tweak copy #186

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

michaelkirk
Copy link
Contributor

@michaelkirk michaelkirk commented Mar 5, 2025

FIXES #136 (mostly done before, but these are the final touches)

Some small tweaks based on our last meeting.

before:
simd-before

after:
simd-after

@michaelkirk michaelkirk force-pushed the mkirk/simd-followup branch 2 times, most recently from 8b30d57 to b54b9f6 Compare March 5, 2025 19:25
people, and a SIMD rank of {props.imd_rank}, putting it in the {props.imd_percentile}
percentile.
people, and a SIMD rank of {props.imd_rank}, making it less deprived
than {props.imd_percentile}% of data zones.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt that "putting it in the 15th percentile" was ambiguous (is that good or bad?) if you aren't already familiar with SIMD ranking conventions. Plus we're no longer showing percentile in the legend as a reference for these units.

"less deprived than 15%" is kind of a weird way to phrase it, but it at least explains that a higher number is better.

Personally, I think "more deprived than 70%" might be more natural to read, but I didn't want to invert the metric, since some people might already be familiar with the concept of SIMD percentiles.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads fine to me. We could ask if "more deprived" would be preferable/easier to read.

@@ -0,0 +1,22 @@
<script>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fork of SequentialLegend from svelte-utils, but the labels fall on the buckets rather than between the buckets (consequently, there's one less label).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I might upstream this and use in NPW too.

Missing TS types, but I'll add them after merging the PR stacks to avoid any rebase headache.

Copy link
Collaborator

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@@ -0,0 +1,22 @@
<script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I might upstream this and use in NPW too.

Missing TS types, but I'll add them after merging the PR stacks to avoid any rebase headache.

people, and a SIMD rank of {props.imd_rank}, putting it in the {props.imd_percentile}
percentile.
people, and a SIMD rank of {props.imd_rank}, making it less deprived
than {props.imd_percentile}% of data zones.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads fine to me. We could ask if "more deprived" would be preferable/easier to read.

@dabreegster dabreegster merged commit 256ea56 into a-b-street:main Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show SIMD per neighbourhoood in the neighbourhood picker
2 participants