Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove holes (lakes) from generated boundaries #204

Conversation

michaelkirk
Copy link
Contributor

@michaelkirk michaelkirk commented Mar 6, 2025

FIXES #145 (just the final bit)

I hadn't really considered this, but this actually has some (small) correctness implications for our prioritization aggregation:

before:
Screenshot 2025-03-06 at 13 10 48

after:
Screenshot 2025-03-06 at 13 13 50

Copy link
Collaborator

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple! Results look much better

@dabreegster dabreegster merged commit 84aecea into a-b-street:main Mar 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing artifacts in autogenerated boundaries
2 participants