Reset map viewport when returning to Choose project and opening a pro… #211
Conversation
| @@ -65,6 +65,8 @@ export let currentProjectKey: Writable<string> = writable(""); | |||
| // False until user activates | |||
| export let showAbout: Writable<boolean> = writable(false); | |||
|
|
|||
| export let appFocus: Writable<"global" | "cnt"> = writable("global"); | |||
There was a problem hiding this comment.
Context is hard to access outside of a component, so I moved it to a store. If you prefer, we could instead try a ChooseProjectLink component, so that context is visible
| if (get(appFocus) == "cnt") { | ||
| bounds = [-8.943, 54.631, -0.901, 59.489]; | ||
| } | ||
| get(map)?.fitBounds(bounds, { duration: 500 }); |
There was a problem hiding this comment.
500 is maybe a little fast, but anything too long gets annoying. What do you think?
There was a problem hiding this comment.
It feels maybe a little fast (definitely not too slow!), but not unreasonable. Let's go with it and we can always tweak it later.
| @@ -154,7 +154,7 @@ export function afterProjectLoaded() { | |||
| writable(0), | |||
| ), | |||
| ); | |||
| get(map)!.fitBounds(get(backend)!.getBounds(), { animate: false }); | |||
| get(map)!.fitBounds(get(backend)!.getBounds(), { duration: 500 }); | |||
There was a problem hiding this comment.
And the other way: when you open a project, animate the zoom in a bit -- again, quickly.
This zoom happens after the load screen. I wanted to do this during the load screen, but we'd have to mimic the backend getBounds, which isn't too clear to do just from the GJ savefile. We could start storing a bbox in there, but I'm not sure it's worth the hassle.
There was a problem hiding this comment.
Doing it during loading rather than after would be nice, but I think that could be a low priority followup task.
| @@ -154,7 +154,7 @@ export function afterProjectLoaded() { | |||
| writable(0), | |||
| ), | |||
| ); | |||
| get(map)!.fitBounds(get(backend)!.getBounds(), { animate: false }); | |||
| get(map)!.fitBounds(get(backend)!.getBounds(), { duration: 500 }); | |||
There was a problem hiding this comment.
Doing it during loading rather than after would be nice, but I think that could be a low priority followup task.
| if (get(appFocus) == "cnt") { | ||
| bounds = [-8.943, 54.631, -0.901, 59.489]; | ||
| } | ||
| get(map)?.fitBounds(bounds, { duration: 500 }); |
There was a problem hiding this comment.
It feels maybe a little fast (definitely not too slow!), but not unreasonable. Let's go with it and we can always tweak it later.
| @@ -65,6 +65,8 @@ export let currentProjectKey: Writable<string> = writable(""); | |||
| // False until user activates | |||
| export let showAbout: Writable<boolean> = writable(false); | |||
|
|
|||
| export let appFocus: Writable<"global" | "cnt"> = writable("global"); | |||
…ject
Fixes #209
Screencast from 08-03-25 11:23:41.webm