Draggable route markers starts on screen. #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are persisted, which is convenient when you want to see how your changes are affecting the route, but it's confusing, especially for new users, to see this route off screen. Maybe another approach would be to zoom the bounds to encompass the marker?
dabreegster
approved these changes
Mar 11, 2025
| returnToChooseProject, | ||
| route_pt_a, | ||
| route_pt_b, | ||
| routePtA, |
There was a problem hiding this comment.
Ah, thanks for cleaning this up. I struggle to switch between underscores and camel-case for Rust/JSON and TS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #72
They are persisted, which is convenient when you want to see how your changes are affecting the route, but it's confusing, especially for new users, to see this route off screen.
Another thought I had, literally after I'd done all the work and was typing up the commit message:
Maybe another approach would be to leave the logic as is, and zoom out the bounds to encompass the markers.