cartographic delights #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buildings are useful context for orienting yourself on the map, especially when you're a local expert who recognizes the landmarks. With the colored cells, it's a bit hard to see the buildings. The 3-d building layer which we used to show while zoomed in was a actually a little easier to distinguish. Now that we're showing the 2-d layer, I've compensated by making it a bit darker.
Lowering the cell fill opacity can cause the cells to be a bit "mushier", so add a border to maintain a crisp distinction between cells.
too will be colored gray.
michaelkirk
force-pushed
the
mkirk/cartographic-delights
branch
from
13d3c50 to
9aa3664
Compare
|
Added some screenshots (how could I forget!) |
|
These cartographic delights have cartographic ends... This is wonderful! Everything looks much crisper. Vendoring the style is definitely the right choice; I think indeed we'll customize it more and more, especially at high zoom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #198 and a followup item mentioned in #220
Really, we could merge any subset of these commits. I tried to keep them separable.
Apart from the individual design changes, the big structural change is that I've vendored the maptiler style.
Alternatively we could continue with the previous pattern of downloading and post-processing the given style, but as our diversions get more complex, it becomes increasingly hard to reason about. There's a reason these style files are declarative!
I also think that it's totally reasonable that we are starting to develop our own cartography - the needs of our app are special, and unique from some platonic "general purpose map".
Screenshots
before:
after: "main" roads are gray
before:
after: most notable here is the relative building and cell contrast
before:
after: most notable here is the relative building and cell contrast