Shortcuts consider routing restrictions on the main road too #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
force-pushed
the
mkirk/spurious-shortcuts
branch
from
a046a66 to
ed18e76
Compare
Previously shortcuts only considered interior roads, starting from the
border intersection, but we need to zoom out just a little bit more and
consider *how* that traffic got to the intersection.
Now routing additionally includes the `main` roads. In order to count
only distinct internal trips, we filter out any routes that use the
perimeter for anything other than starting/ending the trip.
== Perf
Oooph - much slower! It's still pretty fast overall, but I'm going to see if I
can do anything to speed this up.
shortcuts in bristol_east
time: [1.6526 ms 1.6538 ms 1.6552 ms]
change: [+130.08% +131.12% +132.13%] (p = 0.00 < 0.05)
Performance has regressed.
shortcuts in bristol_west
time: [6.0927 ms 6.0966 ms 6.1012 ms]
change: [+121.70% +122.09% +122.45%] (p = 0.00 < 0.05)
Performance has regressed.
shortcuts in strasbourg time: [2.3067 ms 2.3114 ms 2.3193 ms]
change: [+88.807% +89.320% +89.947%] (p = 0.00 < 0.05)
Performance has regressed.
michaelkirk
force-pushed
the
mkirk/spurious-shortcuts
branch
from
ed18e76 to
96a0929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #194
Previously shortcuts only considered interior roads, starting from the border intersection, but we need to zoom out just a little bit more and consider how that traffic got to the intersection.
Now routing additionally includes the
mainroads. In order to count only distinct internal trips, we filter out any routes that use the perimeter for anything other than starting/ending the trip.Screenshots
before: The annotated route is not actually accessible from the restrictions on the perimeter, so it shouldn't show any shortcuts. The "one way" and "modal" edits I've added are maybe not very realistic, but I feel like the turn restriction is a very plausible edit. In any case, they should all work!
after:
