-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start modelling movements at intersections #93
Conversation
…movement at a time.
they occur in the debug mode.
What am I looking at here... 🤔 I initially assumed that the red arrows are illegal moves and the blue one is legal, but that doesn't seem correct. I'd expect there would need to be at least 1 way to either enter or exit each segment. Or maybe I am reading it correctly, and we just haven't fleshed out all the legal turns from the available restrictions yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems good, but I don't quite understand the overall change yet.
to = Some(*w); | ||
} else { | ||
// Some other case, bail out | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with this logic yet, but should these be continue
?
let angle = angle_of_line(line); | ||
Polygon::new( | ||
LineString::new(vec
It's going to be much easier to flesh this out with a better unit testing story. I'm thinking of manually drawing / clipping some test cases in JOSM, checking those in here. For movements, maybe the output can be expressed in the code as a list of movements between named roads, or maybe some GeoJSON / SVG output would be faster to understand.