Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/implicit tagging #126

Merged
merged 10 commits into from
Sep 16, 2024
Merged

Fix/implicit tagging #126

merged 10 commits into from
Sep 16, 2024

Conversation

JesusMcCloud
Copy link
Collaborator

@JesusMcCloud JesusMcCloud commented Sep 16, 2024

closes #13

@iaik-jheher
Copy link
Collaborator

please remove whitespace changes so we can review the actual PR diff

@JesusMcCloud
Copy link
Collaborator Author

JesusMcCloud commented Sep 16, 2024

@iaik-jheher three lines of whitespace? I fail to see the issue
EDIT: Yes, the README got rid of some whitespace

@iaik-jheher
Copy link
Collaborator

resolve conflicts please

Copy link
Collaborator

@iaik-jheher iaik-jheher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved conditional on CI build

@JesusMcCloud
Copy link
Collaborator Author

approved conditional on CI build

the ios fail is a koltin bug. waiting for replies from JB for workarounds

@JesusMcCloud JesusMcCloud merged commit b8cc4a2 into development Sep 16, 2024
6 of 7 checks passed
@JesusMcCloud JesusMcCloud deleted the fix/implicitTagging branch September 16, 2024 16:29
JesusMcCloud added a commit that referenced this pull request Sep 20, 2024
revamp and clean up implicit tagging. this closes #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants