Feature/smooth casting (closes #122) #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaik-jheher
requested changes
Sep 16, 2024
indispensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/Asn1Exception.kt
Outdated
Show resolved
Hide resolved
indispensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/Asn1Elements.kt
Outdated
Show resolved
Hide resolved
indispensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/Asn1Elements.kt
Outdated
Show resolved
Hide resolved
iaik-jheher
reviewed
Sep 16, 2024
indispensable/src/jvmTest/kotlin/at/asitplus/signum/indispensable/CastingTest.kt
Outdated
Show resolved
Hide resolved
iaik-jheher
reviewed
Sep 16, 2024
indispensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/Asn1Elements.kt
Outdated
Show resolved
Hide resolved
…nsable/asn1/Asn1Elements.kt Co-authored-by: Jakob Heher <[email protected]>
iaik-jheher
reviewed
Sep 16, 2024
indispensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/Asn1Elements.kt
Outdated
Show resolved
Hide resolved
…nsable/asn1/Asn1Elements.kt Co-authored-by: Jakob Heher <[email protected]>
iaik-jheher
reviewed
Sep 16, 2024
| * @throws Asn1StructuralException if this element is not a primitive | ||
| */ | ||
| @Throws(Asn1StructuralException::class) | ||
| fun asPrimitive(): Asn1Primitive = casting { this as Asn1Primitive } |
There was a problem hiding this comment.
Suggested change
| fun asPrimitive(): Asn1Primitive = casting { this as Asn1Primitive } | |
| fun asPrimitive() = thisAs<Asn1Primitive>() |
|
incorporated your changes and now it compiles again too |
iaik-jheher
approved these changes
Sep 16, 2024
JesusMcCloud
added a commit
that referenced
this pull request
Sep 20, 2024
* convenience casting of Asn1Elements to more specific subclasses --------- Co-authored-by: Jakob Heher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #122