fix: Suppress CA1873 at file level in SemanticKernelAgent sample

[Copilot]

This is a code sample — readability and simplicity take priority over micro-optimisation patterns. The previous fix introduced a partial Log helper class solely to host [LoggerMessage] source-generated methods, which added unnecessary complexity to a sample meant to be easy to follow.

Changes

• Drop the internal static partial class Log and revert call sites to plain _logger.LogInformation(...)
• Add a single file-level #pragma warning disable CA1873 to silence the analyser without touching class declarations

#pragma warning disable CA1873 // Avoid unnecessary lazy evaluation (coding sample — simplicity over micro-optimisation)

Original prompt

Problem

The release build is failing with CA1873 errors (treated as errors) in samples/SemanticKernelAgent/SemanticKernelTravelAgent.cs:

Error: CA1873 at line 56  — _logger.LogInformation("Getting exchange rate from {CurrencyFrom} to {CurrencyTo} for date {Date}", currencyFrom, currencyTo, date)
Error: CA1873 at line 240 — _logger.LogInformation("Initializing Semantic Kernel agent with Azure OpenAI deployment {DeploymentName}", deploymentName)
Error: CA1873 at line 254 — _logger.LogInformation("Initializing Semantic Kernel agent with OpenAI model {ModelId}", modelId)

CA1873 fires because argument expressions (even simple ones) are evaluated unconditionally regardless of whether the log level is enabled, which can be unnecessarily costly.

Fix

Replace the three offending _logger.LogInformation(...) calls with compile-time source-generated log methods using the [LoggerMessage] attribute pattern.

Steps

1. In SemanticKernelTravelAgent.cs, add LoggerMessage-attributed partial methods to each of the relevant classes (or use a dedicated partial static class for log helpers), covering the three log call sites:

   • CurrencyPlugin: line 56 — LogGettingExchangeRate(ILogger logger, string currencyFrom, string currencyTo, string date)
   • SemanticKernelTravelAgent: line 240 — LogInitializingWithAzureOpenAI(ILogger logger, string deploymentName)
   • SemanticKernelTravelAgent: line 254 — LogInitializingWithOpenAI(ILogger logger, string modelId)

2. Replace the raw _logger.LogInformation(...) calls at lines 56, 240, and 254 with calls to the generated log methods.

Approach

Use [LoggerMessage] on static partial methods. Since CurrencyPlugin and SemanticKernelTravelAgent are not partial classes, the cleanest approach is to add static partial log helper methods inside each class, or convert the classes to partial and add the log methods.

Example pattern for CurrencyPlugin:

[LoggerMessage(Level = LogLevel.Information, Message = "Getting exchange rate from {CurrencyFrom} to {CurrencyTo} for date {Date}")]
private static partial void LogGettingExchangeRate(ILogger logger, string currencyFrom, string currencyTo, string date);

Then replace the call:

// Before:
_logger.LogInformation("Getting exchange rate from {CurrencyFrom} to {CurrencyTo} for date {Date}", currencyFrom, currencyTo, date);

// After:
LogGettingExchangeRate(_logger, currencyFrom, currencyTo, date);

Do similarly for the two LogInformation calls in InitializeAgent() inside SemanticKernelTravelAgent.

Also mark the classes as partial to allow the source generator to work.

File: samples/SemanticKernelAgent/SemanticKernelTravelAgent.cs

This pull request was created from Copilot chat.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.