fix: internal package build after core type changes

[yarolegovich]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @yarolegovich, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing type safety and clarity within the internal task execution and cancellation mechanisms. By introducing dedicated request types for sending messages and canceling tasks, the codebase becomes more explicit about the data expected for these operations. This refactoring ensures that the internal components correctly handle the updated core types, maintaining the integrity and functionality of the task management system.

Highlights

• Type Refactoring: Replaced generic parameter structs (a2a.MessageSendParams, a2a.TaskIDParams) with more specific request types (a2a.SendMessageRequest, a2a.CancelTaskRequest) across the taskexec package.
• API and Interface Updates: Updated the Manager and Factory interfaces in api.go to reflect the new request types for Execute and Cancel operations.
• Implementation Adjustments: Modified distributed_manager.go and local_manager.go to use the new request types in method signatures, struct fields, and internal logic.
• Work Queue Payload Changes: Updated work_queue_handler.go to correctly process workqueue.Payload structures containing the new ExecuteRequest and CancelRequest fields.
• Test Suite Alignment: Adjusted all relevant test files (distributed_manager_test.go, limiter_test.go, manager_test.go, work_queue_handler_test.go) to conform to the new type definitions and API changes.

Changelog

• internal/taskexec/api.go
  • Updated Manager and Factory interfaces to use *a2a.SendMessageRequest and *a2a.CancelTaskRequest for Execute and Cancel methods.
• internal/taskexec/distributed_manager.go
  • Refactored Execute and Cancel methods to accept *a2a.SendMessageRequest and *a2a.CancelTaskRequest respectively.
  • Adjusted internal logic to access fields from the new request types.
• internal/taskexec/distributed_manager_test.go
  • Updated test case structs and Execute calls to use *a2a.SendMessageRequest.
  • Modified Cancel test calls to use *a2a.CancelTaskRequest.
  • Adjusted expected workqueue.Payload structures to include ExecuteRequest and CancelRequest.
• internal/taskexec/limiter_test.go
  • Modified CreateExecutorFn signature in testFactory to accept *a2a.SendMessageRequest.
  • Updated manager.Execute calls in tests to pass *a2a.SendMessageRequest.
• internal/taskexec/local_manager.go
  • Updated cancelation and localExecution structs to use *a2a.CancelTaskRequest and *a2a.SendMessageRequest.
  • Modified newCancelation, newLocalExecution, Execute, createExecution, Cancel, handleExecution, handleCancel, and handleCancelWithConcurrentRun methods to align with new request types.
• internal/taskexec/manager_test.go
  • Updated testFactory method signatures and newStaticFactory to use *a2a.SendMessageRequest and *a2a.CancelTaskRequest.
  • Added newTestSendMessageRequest helper function.
  • Adjusted numerous test calls to manager.Execute and manager.Cancel to use the new request types.
  • Simplified TestManager_GetExecution by removing redundant event consumption and focusing on resubscription.
• internal/taskexec/subscription_test.go
  • Removed the Final: true field from a2a.TaskStatusUpdateEvent in test data.
• internal/taskexec/work_queue_handler.go
  • Updated handle method to check for payload.ExecuteRequest and payload.CancelRequest instead of ExecuteParams and CancelParams.
• internal/taskexec/work_queue_handler_test.go
  • Modified test payloads to use ExecuteRequest and CancelRequest fields with the new a2a.SendMessageRequest and a2a.CancelTaskRequest types.

Activity

• No specific activity (comments, reviews, progress) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the internal packages to align with core type changes, mainly replacing MessageSendParams with SendMessageRequest and TaskIDParams with CancelTaskRequest. The changes are mostly mechanical and look correct. However, I've noticed a reduction in test coverage in one of the test cases, which I've commented on.