feat: update proto convertors in v0#221
Conversation
Summary of ChangesHello @nahapetyan-serob, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring of the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring of core data types and their corresponding Protobuf converters for version v0. The changes aim to create a more unified and consistent type system, which is a positive step for maintainability. The updates to from_proto.go, to_proto.go, and the associated test files are extensive and largely well-executed. I've identified one critical issue in the from_proto.go converter that could lead to a panic due to unsafe slice access. Please see the detailed comment for a suggested fix.
Modified from_proto.go and to_proto.go to address mapping between new core types and old proto types.
Updated existing tests to reflect the converter changes.