fix: Extract taskId from URL path in HTTP+JSON CreateTaskPushNotifica…

[kabir]

…tionConfig

Per HTTP+JSON spec with body: "*", taskId should be extracted from the URL path /tasks/{taskId}/pushNotificationConfigs, not required in request body.

Fixes #732

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compliance issue with the HTTP+JSON specification for creating task push notification configurations. It ensures that the taskId is properly extracted from the URL path, rather than being expected in the request body, thereby correcting the behavior of the API endpoint and resolving a reported bug.

Highlights

• API Specification Compliance: The createTaskPushNotificationConfiguration method now correctly extracts the taskId from the URL path, aligning with the HTTP+JSON specification for this endpoint.
• Bug Fix: Resolved an issue where the taskId was not being set in the TaskPushNotificationConfig builder when creating a new push notification configuration, which previously expected it in the request body.

Changelog

• transport/rest/src/main/java/io/a2a/transport/rest/handler/RestHandler.java
  • Ensured taskId is set from the URL path in createTaskPushNotificationConfiguration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue in the createTaskPushNotificationConfiguration method where the taskId from the URL path was ignored. The change ensures the taskId from the path parameter is used, aligning with the HTTP+JSON specification. I have added one suggestion to make the implementation stricter by validating that if a taskId is present in the request body, it matches the one in the URL path. This would provide better error feedback to clients.

[ehsavoie]

Shouldn't the RestHandlerTest cover that ? testPushNotificationConfigSuccess is using both ids, but I'd like to see the same test without the taskId in the payload